Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy download link dialog #846

Merged
merged 4 commits into from
May 14, 2024
Merged

Copy download link dialog #846

merged 4 commits into from
May 14, 2024

Conversation

zurdi15
Copy link
Member

@zurdi15 zurdi15 commented May 14, 2024

  • Added a dialog to manually copy the download link for a rom at unsecured context

image

Closes #818

@zurdi15 zurdi15 added bug Something isn't working feature New feature or request ui/ux UI/UX improvements or suggestions labels May 14, 2024
@zurdi15 zurdi15 requested a review from gantoine May 14, 2024 00:54
@zurdi15 zurdi15 self-assigned this May 14, 2024
Copy link

Test Results

73 tests  ±0   73 ✅ ±0   23s ⏱️ -1s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit f630889. ± Comparison against base commit e70ff6c.

Copy link
Member

@gantoine gantoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it

@zurdi15 zurdi15 merged commit e155efd into master May 14, 2024
5 checks passed
@zurdi15 zurdi15 deleted the feature/copy-download-link branch May 14, 2024 06:31
@zurdi15 zurdi15 mentioned this pull request May 31, 2024
spiceratops referenced this pull request in spiceratops/k8s-gitops Jun 8, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [rommapp/romm](https://github.com/rommapp/romm) | minor | `3.1.0` ->
`3.2.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>rommapp/romm (rommapp/romm)</summary>

### [`v3.2.0`](https://github.com/rommapp/romm/releases/tag/3.2.0)

[Compare
Source](https://github.com/rommapp/romm/compare/3.1.0...3.2.0)

### BIOS file support

We've added the ability to mount (or upload) your BIOS/firmware files
for any of the supported platforms. On top of that, when playing in
browser with our EmulatorJS integration, you'll now be able to select
both a BIOS file to load, and a core (when the system supports more then
1 core). Refer to the EmulatorJS for the complete list of available
cores for each system.

### Sharable & private notes

When viewing a game, you might notice a new tab called "Notes"; this is
your notepad, a blank space to jot down just about anything. With full
Markdown support, you have complete control over the style and layout of
your note.
You're also able to make the note "public" (using the little eye icon
next to the pencil), that is visible to every logged-in user on your
instance. And if they do the same, you'll get access to their note, for
easy sharing of tips and tricks.

|||
|---|---|

|![image](https://github.com/rommapp/romm/assets/34356590/84d0d5d4-334d-4bc4-a4a5-e62e7d5f3079)|![image](https://github.com/rommapp/romm/assets/34356590/521697ba-608c-4a24-bafc-1933d1fea615)|

### Performance improvements

On collections of 1000+ games/platforms with 250+ roms, we've measured a
10x to 20x improvement in load times. RomM should now feel faster
regardless of the size of your collection, with smoother gallery
navigation, faster loading of games on scroll, and real pagination
support in the list view.

#### What's Changed

- Games notes by [@&#8203;gantoine](https://github.com/gantoine) in
[https://github.com/rommapp/romm/pull/828](https://github.com/rommapp/romm/pull/828)
- Copy download link dialog by
[@&#8203;zurdi15](https://github.com/zurdi15) in
[https://github.com/rommapp/romm/pull/846](https://github.com/rommapp/romm/pull/846)
- Firmware/BIOS support by
[@&#8203;gantoine](https://github.com/gantoine) in
[https://github.com/rommapp/romm/pull/830](https://github.com/rommapp/romm/pull/830)
- Upgraded front packages and adapted code by
[@&#8203;zurdi15](https://github.com/zurdi15) in
[https://github.com/rommapp/romm/pull/847](https://github.com/rommapp/romm/pull/847)
- Python package changes by
[@&#8203;gantoine](https://github.com/gantoine) in
[https://github.com/rommapp/romm/pull/844](https://github.com/rommapp/romm/pull/844)
- Fixed gallery play button for not supported platforms by
[@&#8203;zurdi15](https://github.com/zurdi15) in
[https://github.com/rommapp/romm/pull/848](https://github.com/rommapp/romm/pull/848)
- Fixed updating user images and ignore firmware files based on config
by [@&#8203;gantoine](https://github.com/gantoine) in
[https://github.com/rommapp/romm/pull/851](https://github.com/rommapp/romm/pull/851)
- Purge platforms correctly on scan by
[@&#8203;gantoine](https://github.com/gantoine) in
[https://github.com/rommapp/romm/pull/858](https://github.com/rommapp/romm/pull/858)
- Ruff-only pre-commit hooks by
[@&#8203;gantoine](https://github.com/gantoine) in
[https://github.com/rommapp/romm/pull/855](https://github.com/rommapp/romm/pull/855)
- Added amiibo platform icon by
[@&#8203;Casuallynoted](https://github.com/Casuallynoted) in
[https://github.com/rommapp/romm/pull/869](https://github.com/rommapp/romm/pull/869)
- Fixed emulatorjs game loading when game have non-ascii characters in
the name by [@&#8203;vincywindy](https://github.com/vincywindy) in
[https://github.com/rommapp/romm/pull/872](https://github.com/rommapp/romm/pull/872)
- Fix search by ID for mobygames by
[@&#8203;gantoine](https://github.com/gantoine) in
[https://github.com/rommapp/romm/pull/863](https://github.com/rommapp/romm/pull/863)
- Platform fetch performance improvements by
[@&#8203;gantoine](https://github.com/gantoine) in
[https://github.com/rommapp/romm/pull/857](https://github.com/rommapp/romm/pull/857)
- Fixed uploading images for roms and users by
[@&#8203;gantoine](https://github.com/gantoine) in
[https://github.com/rommapp/romm/pull/874](https://github.com/rommapp/romm/pull/874)
- Fixed rom download by
[@&#8203;vincywindy](https://github.com/vincywindy) in
[https://github.com/rommapp/romm/pull/876](https://github.com/rommapp/romm/pull/876)
- Improved general performance (10x faster load at home page and
galleries) by [@&#8203;gantoine](https://github.com/gantoine) in
[https://github.com/rommapp/romm/pull/875](https://github.com/rommapp/romm/pull/875)
- Fixed scan view selectors by
[@&#8203;zurdi15](https://github.com/zurdi15) in
[https://github.com/rommapp/romm/pull/878](https://github.com/rommapp/romm/pull/878)
- Whats new link fixed by
[@&#8203;zurdi15](https://github.com/zurdi15) in
[https://github.com/rommapp/romm/pull/880](https://github.com/rommapp/romm/pull/880)
- Only scan platform when selected by
[@&#8203;gantoine](https://github.com/gantoine) in
[https://github.com/rommapp/romm/pull/882](https://github.com/rommapp/romm/pull/882)
- Improved performance of Rom DB fetch by
[@&#8203;gantoine](https://github.com/gantoine) in
[https://github.com/rommapp/romm/pull/883](https://github.com/rommapp/romm/pull/883)

#### New Contributors

- [@&#8203;vincywindy](https://github.com/vincywindy) made their first
contribution in
[https://github.com/rommapp/romm/pull/872](https://github.com/rommapp/romm/pull/872)
- [@&#8203;Deekerman](https://github.com/Deekerman) a special shoutout
for being a right PITA

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zODIuNCIsInVwZGF0ZWRJblZlciI6IjM3LjM4Mi40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL21pbm9yIl19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature New feature or request ui/ux UI/UX improvements or suggestions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants