-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Improve Docker layer caching on frontend changes #948
fix: Improve Docker layer caching on frontend changes #948
Conversation
Avoid any changes in the `frontend/` folder to trigger `npm install`. Instead, split the copies to have separate steps for install and build.
ccaa8e0
to
32ef612
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice 💯
Tried building this on my server and it failed on
|
I'm not being able to reproduce the error. This is the command I'm using, to disable cache, and pull latest versions for the referenced images, to avoid any existing state. Also building just the frontend target, to validate faster. docker build --pull --no-cache -t romm:local-frontend --target front-build-stage . --file ./docker/Dockerfile |
Strange, I run it using the same command and it failed again, with the same error. I'll have a closer look at it later. |
It's possible the |
yeah that was it! removing it i'm now able to build consistently 🎉 |
Avoid any changes in the
frontend/
folder to triggernpm install
. Instead, split the copies to have separate steps for install and build.