Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid orphan collections table on migration fail #992

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Avoid orphan collections table on migration fail #992

merged 3 commits into from
Jul 11, 2024

Conversation

zurdi15
Copy link
Member

@zurdi15 zurdi15 commented Jul 10, 2024

Doing the resources migration first avoids having an orphaned collections table on fail

@zurdi15 zurdi15 requested a review from gantoine July 10, 2024 20:23
@zurdi15 zurdi15 self-assigned this Jul 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

Test Results

72 tests  ±0   72 ✅ ±0   21s ⏱️ -1s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit da6adfe. ± Comparison against base commit 7590fd3.

♻️ This comment has been updated with latest results.

@zurdi15 zurdi15 requested a review from gantoine July 10, 2024 21:48
gantoine
gantoine approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@gantoine gantoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@zurdi15 zurdi15 merged commit 6d6cb35 into master Jul 11, 2024
8 checks passed
@zurdi15 zurdi15 deleted the fix/collections-migration branch July 11, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gantoine gantoine gantoine approved these changes

Assignees

@zurdi15 zurdi15

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zurdi15 @gantoine