Skip to content

Commit

Permalink
Make NestedObjectMapper its own class (elastic#74410)
Browse files Browse the repository at this point in the history
Nested objects are implemented via a Nested class directly on object mappers,
even though nested and non-nested objects have quite different semantics. In
addition, most call-sites that need to get an object mapper in fact need a nested
object mapper. To make it clearer that nested and object mappers are different
beasts with different implementations and different requirements, we should
split them into different classes.

server:test compiles
  • Loading branch information
romseygeek committed Jul 19, 2021
1 parent cf575f4 commit 1920f00
Showing 1 changed file with 0 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,6 @@ private static void fixRedundantIncludes(ObjectMapper objectMapper, boolean pare
child.setIncludeInParent(true);
child.setIncludeInRoot(false);
}
fixRedundantIncludes(child, includeInRootViaParent || includedInRoot);
}
}
}
Expand Down

0 comments on commit 1920f00

Please sign in to comment.