Skip to content

Commit

Permalink
Document extraContainers and extraInitContainers that are templat…
Browse files Browse the repository at this point in the history 
…ed (apache#40033)

Most of the Airflow pods have templated `extraContainers` and
`extraInitContainers`, but were missed being documented as such.
  • Loading branch information
@jedcunningham @romsharon98
jedcunningham authored and romsharon98 committed Jul 26, 2024
1 parent 2d11e9f commit e93926f
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 20 deletions.
20 changes: 10 additions & 10 deletions chart/values.schema.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1864,15 +1864,15 @@
"default": true
},
"extraContainers": {
"description": "Launch additional containers into workers. Note, if used with KubernetesExecutor, you are responsible for signaling sidecars to exit when the main container finishes so Airflow can continue the worker shutdown process!",
"description": "Launch additional containers into workers (templated). Note, if used with KubernetesExecutor, you are responsible for signaling sidecars to exit when the main container finishes so Airflow can continue the worker shutdown process!",
"type": "array",
"default": [],
"items": {
"$ref": "#/definitions/io.k8s.api.core.v1.Container"
}
},
"extraInitContainers": {
"description": "Add additional init containers into workers.",
"description": "Add additional init containers into workers (templated).",
"items": {
"$ref": "#/definitions/io.k8s.api.core.v1.Container"
},
Expand Down Expand Up @@ -2442,15 +2442,15 @@
"default": true
},
"extraContainers": {
"description": "Launch additional containers into scheduler.",
"description": "Launch additional containers into scheduler (templated).",
"type": "array",
"default": [],
"items": {
"$ref": "#/definitions/io.k8s.api.core.v1.Container"
}
},
"extraInitContainers": {
"description": "Add additional init containers into scheduler.",
"description": "Add additional init containers into scheduler (templated).",
"type": "array",
"default": [],
"items": {
Expand Down Expand Up @@ -2908,15 +2908,15 @@
"default": true
},
"extraContainers": {
"description": "Launch additional containers into triggerer.",
"description": "Launch additional containers into triggerer (templated).",
"type": "array",
"default": [],
"items": {
"$ref": "#/definitions/io.k8s.api.core.v1.Container"
}
},
"extraInitContainers": {
"description": "Add additional init containers into triggerer.",
"description": "Add additional init containers into triggerer (templated).",
"type": "array",
"default": [],
"items": {
Expand Down Expand Up @@ -3399,15 +3399,15 @@
"default": true
},
"extraContainers": {
"description": "Launch additional containers into dag processor.",
"description": "Launch additional containers into dag processor (templated).",
"type": "array",
"default": [],
"items": {
"$ref": "#/definitions/io.k8s.api.core.v1.Container"
}
},
"extraInitContainers": {
"description": "Add additional init containers into dag processor.",
"description": "Add additional init containers into dag processor (templated).",
"type": "array",
"default": [],
"items": {
Expand Down Expand Up @@ -4677,15 +4677,15 @@
}
},
"extraContainers": {
"description": "Launch additional containers into webserver.",
"description": "Launch additional containers into webserver (templated).",
"type": "array",
"default": [],
"items": {
"$ref": "#/definitions/io.k8s.api.core.v1.Container"
}
},
"extraInitContainers": {
"description": "Add additional init containers into webserver.",
"description": "Add additional init containers into webserver (templated).",
"type": "array",
"default": [],
"items": {
Expand Down
20 changes: 10 additions & 10 deletions chart/values.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -678,11 +678,11 @@ workers:
# when it wants to scale a node down.
safeToEvict: true

# Launch additional containers into worker.
# Launch additional containers into worker (templated).
# Note: If used with KubernetesExecutor, you are responsible for signaling sidecars to exit when the main
# container finishes so Airflow can continue the worker shutdown process!
extraContainers: []
# Add additional init containers into workers.
# Add additional init containers into workers (templated).
extraInitContainers: []

# Mount additional volumes into worker. It can be templated like in the following example:
Expand Down Expand Up @@ -887,9 +887,9 @@ scheduler:
# when it wants to scale a node down.
safeToEvict: true

# Launch additional containers into scheduler.
# Launch additional containers into scheduler (templated).
extraContainers: []
# Add additional init containers into scheduler.
# Add additional init containers into scheduler (templated).
extraInitContainers: []

# Mount additional volumes into scheduler. It can be templated like in the following example:
Expand Down Expand Up @@ -1270,9 +1270,9 @@ webserver:
lastName: user
password: admin

# Launch additional containers into webserver.
# Launch additional containers into webserver (templated).
extraContainers: []
# Add additional init containers into webserver.
# Add additional init containers into webserver (templated).
extraInitContainers: []

# Mount additional volumes into webserver. It can be templated like in the following example:
Expand Down Expand Up @@ -1456,9 +1456,9 @@ triggerer:
# when it wants to scale a node down.
safeToEvict: true

# Launch additional containers into triggerer.
# Launch additional containers into triggerer (templated).
extraContainers: []
# Add additional init containers into triggerers.
# Add additional init containers into triggerers (templated).
extraInitContainers: []

# Mount additional volumes into triggerer. It can be templated like in the following example:
Expand Down Expand Up @@ -1639,9 +1639,9 @@ dagProcessor:
# when it wants to scale a node down.
safeToEvict: true

# Launch additional containers into dag processor.
# Launch additional containers into dag processor (templated).
extraContainers: []
# Add additional init containers into dag processors.
# Add additional init containers into dag processors (templated).
extraInitContainers: []

# Mount additional volumes into dag processor. It can be templated like in the following example:
Expand Down

0 comments on commit e93926f

Please sign in to comment.