Fixed windows build behind proxy #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have to merge faster first, hmm? But please please please. 😊 👍 |
|
Can you fix the conflict? |
|
Yeah, I can fix the conflict. Just give me a while to make the change and test to ensure it still works. I'll post here again when it is good to go. ;) |
Added casperjs to package.json so that npm could take care of downloading casper rather than doing it via the install.js script. Removed install.js file since it wasn't needed. Modified casperjs script to simply look for casper in the correct location Added npm install Added npm preinstall Added Node platform detection for casperjs to run on Windows
|
Just ran a quick test and everything appears to be fine. |
TechNickAI
added a commit
that referenced
this pull request
Aug 17, 2014
Fixed windows build behind proxy
|
Published as grunt-casperjs 2.0 |
|
Should also fix #61 |
|
Resolves #57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update is to allow this grunt task to work behind a corporate proxy (using npm) and also allow it to run correctly on a Windows environment which it did not seem to do (I see someone else created an issue here that was similar #61 ). I've been using this for quite a while in our environment and it appears to work fine. I just thought I'd clean up the commits and do a pull request back to you guys so you could take advantage of this change.