Skip to content

Commit

Permalink
Update todo list
Browse files Browse the repository at this point in the history
  • Loading branch information
ronaldoussoren committed Jul 10, 2024
1 parent e564462 commit 45716a6
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions src/py2app/_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -904,6 +904,18 @@ def build_bundle(

architecture, deployment_target, warnings = audit_macho_issues(paths.root.parent)

# XXX: Validate the 'architecture':
# - Error out when 'architecture' is None (no architecture supports all Mach-O files)
# - Two options:
# - Change stub executables to match the architecture
# - Error out when architecture doesn't match *bundle.macho_arch*
# (The latter is more explicit, but will result in failures when
# using a universal build of Python with single-arch wheels, which can
# be annoying when not targeting other systems)
# (For the first option: easiest would be to move creating the stub
# executables to this point, although this requires redoing some of the
# work of _standalone)

# Set the deployment target for the launcher executables to the lowest
# deployment target of Mach-O files in the bundle.
# XXX: Check and document the error message for launching the bundle on
Expand Down

0 comments on commit 45716a6

Please sign in to comment.