Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use crud client lib #217

Merged
merged 3 commits into from
Jul 5, 2023
Merged

feat: use crud client lib #217

merged 3 commits into from
Jul 5, 2023

Conversation

davidebianchi
Copy link
Member

No description provided.

@davidebianchi davidebianchi added the enhancement New feature or request label Jul 5, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5462108622

  • 38 of 52 (73.08%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.8%) to 83.766%
Changes Missing Coverage Covered Lines Changed/Added Lines %
helpers/headers_to_proxy.go 0 14 0.0%
Totals Coverage Status
Change from base Build 5422808538: -0.8%
Covered Lines: 1677
Relevant Lines: 2002
💛 - Coveralls

@fredmaggiowski fredmaggiowski added bug Something isn't working refactor and removed enhancement New feature or request labels Jul 5, 2023
fredmaggiowski
fredmaggiowski approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@fredmaggiowski fredmaggiowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fredmaggiowski fredmaggiowski merged commit 5448ebc into main Jul 5, 2023
6 checks passed
@fredmaggiowski fredmaggiowski deleted the feat/migrate-crud-client branch July 5, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredmaggiowski fredmaggiowski fredmaggiowski approved these changes

@Danielecina Danielecina Danielecina left review comments

Assignees
No one assigned
Labels
bug Something isn't working refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidebianchi @coveralls @fredmaggiowski @Danielecina