Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log with inherited fields #367

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

davidebianchi
Copy link
Member

Resolves #366

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10142403492

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.91%

Totals Coverage Status
Change from base Build 9881716284: 0.0%
Covered Lines: 2324
Relevant Lines: 2737

💛 - Coveralls

Copy link
Member

@fredmaggiowski fredmaggiowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fredmaggiowski fredmaggiowski merged commit 5bcd2af into main Jul 29, 2024
18 checks passed
@fredmaggiowski fredmaggiowski deleted the fix/log-with-inherited-field branch July 29, 2024 10:31
@fredmaggiowski fredmaggiowski added bug Something isn't working technical debt This brings or resolves technical debt labels Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working technical debt This brings or resolves technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some log records does not forward the request id
3 participants