Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patch to display quote-posts on status cards #125

Closed
wants to merge 1 commit into from

Conversation

richarvey
Copy link

Many mastodon clients are now allowing users to quote post and include the original post in the new post within a status card. This doesn't display on the web ui but would be a nice added feature. The change is ~6 lines of code which means the web ui and all the other clients will pick up the URL from a quoted post and make it a status card.

It's a nice feature to add and it's been tested out on awscommunity.social implemented via the CSS method.

@ronilaukkarinen
Copy link
Owner

Okay I have reviewed the PR.

Some notes:

  1. Build fails, please edit the pull according to the stylelint ruleset
  2. Styles should be added to both single and multiple column layout and use the .layout-single-column class in single side and .layout-multiple-columns in multiple column layout
  3. What if we have an image with a long test like in this example? This does not look right:

image

@ronilaukkarinen
Copy link
Owner

Tangerine UI has this enabled with image on the right side with border radius. I could experiment with that in some point. Another PR welcome if you want to try it out.

@ronilaukkarinen
Copy link
Owner

Since quote posts are being worked on anyway, I'm just going to close this PR...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants