Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow LaTeXStrings #186

Merged
merged 4 commits into from
Oct 11, 2022
Merged

allow LaTeXStrings #186

merged 4 commits into from
Oct 11, 2022

Conversation

BeastyBlacksmith
Copy link
Contributor

@BeastyBlacksmith BeastyBlacksmith commented Oct 5, 2022

As I said in https://discourse.julialang.org/t/course-about-creating-reports-with-julia/87570/16?u=beastyblacksmith LaTeXStrings is a benign dependency, that enables composition by multiple dispatch.
As a user, I don't want to have the resposibility to check whether the output of package A is a valid latexstring when passing it to package B. Therefore you need to have a messanger type thats neither part of package A or B.
And that is a good thing.

@ronisbr
Copy link
Owner

ronisbr commented Oct 5, 2022

The problem is that LaTeXString is not in Julia stdlib. As I said, this can escalate quickly. What about the same problem in HTML? What should we do if another package does something similar to LaTeXString? PrettyTables is suppose to be a low level printing package that others can use.

Can you please point me a real situation that adding this dependency to PrettyTables will be almost impossible to circumvent?

@bkamins What do you think? In the past, we removed Parameters.jl, which added a similar loading time, to keep the dependencies as small as possible.

@bkamins
Copy link

bkamins commented Oct 5, 2022

Weighing pros and cons, my thinking is as follows:

  1. Parameters.jl is developer oriented; it can be dropped without impacting user experience.
  2. LaTeXStrings.jl is end-user oriented; it is aimed to make user's life easier

So it means that LateXStrings.jl should have a preference over Parameters.jl to be included. Now there are two considerations:

  1. Is LaTeXStrings.jl lightweight: yes it is, it is I think 3x smaller than Parameters.jl;
  2. Does LaTeXStrings.jl ensure proper maintenance: I think yes given that it has wide adoption, is a simple package (no need of changes), is maintained by @stevengj, who ensures quality.

In conclusion: if users need it I would accept it.

@ronisbr
Copy link
Owner

ronisbr commented Oct 5, 2022

Ok! So let’s add this dependency!

@BeastyBlacksmith can you please add tests considering cells with LaTeXStrings?

@ronisbr
Copy link
Owner

ronisbr commented Oct 6, 2022

I did some minor modifications. If the test passes, I will merge.

@ronisbr ronisbr merged commit f633fac into ronisbr:master Oct 11, 2022
@ronisbr
Copy link
Owner

ronisbr commented Oct 11, 2022

Merged! Thanks @BeastyBlacksmith !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants