-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow LaTeXStrings #186
allow LaTeXStrings #186
Conversation
The problem is that LaTeXString is not in Julia stdlib. As I said, this can escalate quickly. What about the same problem in HTML? What should we do if another package does something similar to LaTeXString? PrettyTables is suppose to be a low level printing package that others can use. Can you please point me a real situation that adding this dependency to PrettyTables will be almost impossible to circumvent? @bkamins What do you think? In the past, we removed Parameters.jl, which added a similar loading time, to keep the dependencies as small as possible. |
Weighing pros and cons, my thinking is as follows:
So it means that LateXStrings.jl should have a preference over Parameters.jl to be included. Now there are two considerations:
In conclusion: if users need it I would accept it. |
Ok! So let’s add this dependency! @BeastyBlacksmith can you please add tests considering cells with LaTeXStrings? |
I did some minor modifications. If the test passes, I will merge. |
Merged! Thanks @BeastyBlacksmith ! |
As I said in https://discourse.julialang.org/t/course-about-creating-reports-with-julia/87570/16?u=beastyblacksmith LaTeXStrings is a benign dependency, that enables composition by multiple dispatch.
As a user, I don't want to have the resposibility to check whether the output of package A is a valid latexstring when passing it to package B. Therefore you need to have a messanger type thats neither part of package A or B.
And that is a good thing.