Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ”₯ Active Storage Instead Of Shrine #35

Merged
merged 41 commits into from
Jun 22, 2023
Merged

Conversation

roniy68
Copy link
Owner

@roniy68 roniy68 commented Jun 20, 2023

Highlights πŸ₯‡

What I Have Done:

βœ… Install active_storage into the project

bundle add image_processing
rails active_storage:install

βœ… Configure active_storage
βœ… has_one_attached :image

Needs Check:

βœ… Needs Check and confirmation of image uploads.

Fails πŸ”΄

πŸ”₯ Fails To Create A Car but active_storage works

Local Installation

bundle install &&  EDITOR="code --wait" rails credentials:edit 

put your db user and pass as env variable

POSTGRESQL_USER: username
POSTGRESQL_PASSWORD: password
RAILSBLOG_DATABASE_PASSWORD: password

πŸ‘₯ Authors

Missed anything?

  • Explained the purpose of this PR.
  • Self reviewed the PR.
  • Added or updated test cases.
  • Informed of breaking changes, testing and migrations (if applicable).
  • Updated documentation (if applicable).
  • Attached screenshots (if applicable).

Followed Rules:

Copy link
Collaborator

@Talha-Hanif5666 Talha-Hanif5666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVEDπŸŸ’βœ”

Hi @roniy68 πŸ‘‹

You have done very well in creating the application, it looks really impressive. πŸ‘
There is nothing else to say other than... it's time to merge it . :shipit:
Congratulations! πŸŽ‰

159485323-11dfc0c5-bd53-4956-b55a-2fc42f7a3845

Highlights 🌟

  • Nice design implementationβœ”
  • All functionalities work fineβœ”
  • Good commit messages βœ”
  • Good Code Structure βœ”
  • All tests are passingβœ”

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Important Notes πŸ“

  • Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
  • Please, remember to tag me in your question so I can receive the notification.

@roniy68 roniy68 linked an issue Jun 22, 2023 that may be closed by this pull request
@Talha-Hanif5666 Talha-Hanif5666 linked an issue Jun 22, 2023 that may be closed by this pull request
@roniy68 roniy68 merged commit a0d6322 into development Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants