π₯ Final group capstone - Book an Appointment #42
Conversation
β rails g model user username β rails g model car name description:text .... etc
β rails g model reservation city pick_up:date ...
CAR and Reservation
β rails g controller api/v1/Cars index show create destroy --skip-template --no-helper
β create, show, destroy
There was a problem hiding this comment.
Hi @roniy68,
Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation, but you are almost there!
To highlight:
- Tests are passingβοΈ
- Nice code organization βοΈ
- App is working wellβοΈ
- Good readme βοΈ
- Beautiful frontend βοΈ
You are really close to finishing the Microverse program!! Keep it up! πππ
After implementing the requested changes, please submit another review request. β»οΈ
Check the comments under the review.
Cheers and Happy coding!πππ
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the previous reviews unless it is requested otherwise.
| @@ -0,0 +1,83 @@ | |||
| @import url('https://fonts.googleapis.com/css2?family=Poppins&display=swap'); | |||
There was a problem hiding this comment.
- There are some overflow problems in the mobile view (tested both on Chrome and Firefox):
Kindly fix these overflow problems on your styling, so your mobile app looks more professional and beautiful. πͺ
There was a problem hiding this comment.
π₯ Fixed The Responsiveness
https://www.loom.com/share/ab17f762d1a44bad804d3d480ca30909?sid=33e79aad-b43b-4ec3-9537-0a73d4678dcf
README.md
Outdated
| ```sh | ||
| yarn install | ||
| ``` | ||
|
|
||
| ```sh | ||
| npm install | ||
| ``` |
There was a problem hiding this comment.
- OPTIONAL: Be careful here. Are both npm and yarn needed? Or just one of them?
Since your project works and may depend on both, I leave this as and optional heads-up. π
There was a problem hiding this comment.
π₯ Cleared The Confusion with or
There was a problem hiding this comment.
According to the Javascript general best practices requirements:
Therefore:
-
Kindly, remove the
console.logdebugging statements present on this file so the app's cleanliness is improved. -
Also, please kindly remove the
console.logstatements on these other files:
That way, we will meet this requirement. π
There was a problem hiding this comment.
π₯ Removed Debugging Logs.
|
Thank you @Meltrust for your sincere review β€οΈ , we'll work on the required changes. |
β¦s into required_changes
π₯ Changes Required : Checked :check
|
π₯ Fixed Issues : β
Mobile Responsiveness π₯ Loom : |
There was a problem hiding this comment.
Hi @roniy68,
Wow, you did it π
Thank you for the changes implemented πͺ π₯ γοΈ
Unless you want to add more features, go ahead to your final presentation β© β© β©
You are about to finish the Microverse program. You have come a long way!!!
Good luck in the software industry!! I'll see you there. β¨
Congratulations!!!!!! π
To highlight
- Mobile view styling has been fixedβοΈ
- Node vs Yarn confusion has been cleared upβοΈ
- Functions are now ES6βοΈ
- Splendid job βοΈ
Cheers and Happy coding!πππ
π₯ Create A Beautiful Documentation
π₯ CODE_OF_CONDUCT π₯
Contributing
π₯ Security.md
π₯ Hi @Meltrust,Thank you so much for your enthusiastic and encouraging review! π I'm thrilled to hear that you are impressed with the changes I implemented. It means a lot to me. I really appreciate your confidence in my work and your suggestion to add more features. I'll definitely consider it and if I find any valuable additions, I'll make sure to include them before my final presentation. β© β© β© The Microverse program has been quite a journey, and I'm grateful for your support and kind words. It's been challenging, but also incredibly rewarding. I'm excited to step into the software industry and put my skills to good use. I hope to meet you there as well! β¨ Thank you once again for highlighting the improvements made. I'm glad the mobile view styling is fixed, the Node vs Yarn confusion is cleared up, and the functions are now in ES6. It's always satisfying to see progress and overcome obstacles. β I raise my virtual glass to you, and here's to happy coding and continued success! π π π Cheers! Happy Coding !!!π₯ π πͺ π₯ π π π©βπ» π¨βπ» π π β¨ π π π π π π π π π π π |
Highlights π₯
Hello @Reviewer, we are three team members in this project. And Followed This Requirements
What Has Been Done:
β The user logs in to the website, only by typing the username [ For Three People Work]
β In the navigation panel, the user can see links to:
Cars items .
β On the main page, the user can see the list of models in a carousel
β When the user selects a specific item, they can see the [details page]
β When the user clicks the "Add Car" link in the navigation panel they can see a form for adding a new item.
β Make the app responsive, creating both mobile and desktop versions.
β When the user clicks the "Delete item" link in the navigation panel they can see a list of all items with title and "Delete" button.
β When the user clicks the "My reservations" link in the navigation panel they can see a list of their reservations (with information about item name, date and city).
β Add full documentation for your API.
Tech Setup
β Set up the repository/repositories on GitHub and use Gitflow.
β should use Postgres as your database
β Use Rails to create backend API.
β Use React & Redux to create frontend UI.
β You can choose if you want to set up your project as two separate apps or as one.
β The Creative Commons license of the design requires that you give appropriate credit to the author. Therefore, you must do it in the README of your project.
Kanban Board
Kanban Board
Live Link
Live Here
Local Installation
put your db user and pass as env variable
π₯ Authors
Missed anything?
Followed Rules: