Replaced log4j dependency with SLF4J #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 27, 2013 10:58
SLF4J is a better dependency for code used in potentially many projects, as it doesn't couple a specific logging dependency to the shared code.
Changed documentation to reflect updated dependency on slf4j instead of log4j.
|
Hello fragnemesis, Glad you find it useful! As of SLF4J, I always find it hard to use the logging tools... but my projects are using log4j in other places too, so I would keep it like this for now.. Thanks. |
added 2 commits
March 19, 2013 12:41
Changed fields and getters/setters to comply with Java naming conventions.
int is multiplied by 1000 and this value is greater than int.MAX_VALUE, a wraparound will occur resulting in a large negative number. This will effectively make the timeout end immediately instead of lasting indefinitely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't use log4j, so I needed to replace the logging dependency with something that would work for me. SLF4J is a great library for creating a nice API that can be used as a facade for a multitude of logging frameworks. It's highly recommended as a dependency replacement for log4j.
Great work on the Expect implementation, btw! I looked at the other Expect Java libraries before coming here, and neither of them worked the way that I wanted. Your implementation is much simpler, making it easier to modify and integrate into other projects.