Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with spreadsheets containing filters #543

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Fix issue with spreadsheets containing filters #543

merged 1 commit into from
Feb 6, 2023

Conversation

coorasse
Copy link
Contributor

@coorasse coorasse commented Oct 6, 2020

This PR tackles and closes #533 and #276

@md5
Copy link

md5 commented Feb 2, 2023

@kakubin any chance you could take a look at this PR? I'm in the process of updating one of our apps and saw that we're maintaining an internal fork of this gem that has nearly identical fix to this one.

Apologies if you're not the right person to ping, but I see that you've merged some recent PRs.

@kakubin
Copy link
Contributor

kakubin commented Feb 6, 2023

I've been removed my authority, so I honestly don't know what my role is.

@kakubin
Copy link
Contributor

kakubin commented Feb 6, 2023

@patrickkulling Would you be willing to review it too?

@patrickkulling
Copy link
Contributor

I will have a look later today

@patrickkulling patrickkulling self-assigned this Feb 6, 2023
@patrickkulling patrickkulling self-requested a review February 6, 2023 07:38
patrickkulling
patrickkulling approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@patrickkulling patrickkulling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and looking good

@patrickkulling patrickkulling merged commit 92634fb into roo-rb:master Feb 6, 2023
@md5
Copy link

md5 commented Feb 6, 2023

Thanks @patrickkulling! It looks like there are a fair number of changes post-v2.9.0 that would be helpful to get into a v2.10.0 release. Any chance that is in the works?

@patrickkulling
Copy link
Contributor

@md5 There is one additional PR that I would like to see back at least but I agree that we should be planning to release a new version of roo soon.

I will try to figure out how that has been done in the past.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kakubin kakubin kakubin approved these changes

@patrickkulling patrickkulling patrickkulling approved these changes

Assignees

@patrickkulling patrickkulling

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem with broken links
4 participants
@coorasse @md5 @kakubin @patrickkulling