Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rooch-framework/crypto base64 #1161

Closed
Tracked by #769
yubing744 opened this issue Nov 18, 2023 · 3 comments
Closed
Tracked by #769

rooch-framework/crypto base64 #1161

yubing744 opened this issue Nov 18, 2023 · 3 comments
Assignees
@yubing744
Labels
area:stdlib Move stdlib or framework issues help wanted Extra attention is needed skill::move Need the Move language skill to complete the issue skill::rust Need the rust language skill to complete the issue
Milestone
Rooch v0.8

Comments

@yubing744
Copy link
Collaborator

yubing744 commented Nov 18, 2023 •
edited
Loading

Base64 decoding needs to be implemented in the Move contract for JWT header and body decoding.
@yubing744 yubing744 mentioned this issue Nov 18, 2023
Open
13 tasks
@yubing744 yubing744 added the help wanted Extra attention is needed label Nov 18, 2023
@yubing744 yubing744 self-assigned this Nov 20, 2023
@jolestar jolestar added the area:stdlib Move stdlib or framework issues label Nov 23, 2023
@jolestar jolestar added this to the Rooch v0.3 milestone Nov 23, 2023
@jolestar jolestar added skill::move Need the Move language skill to complete the issue skill::rust Need the rust language skill to complete the issue labels Nov 23, 2023
@jolestar
Copy link
Contributor

Use a native function like https://github.com/rooch-network/rooch/blob/f7573bb942b956097e0d1f06a61770ee1f8c60f0/crates/rooch-framework/sources/crypto/decoding.move

Or use a pure Move implement:

https://github.com/movefuns/movefuns/blob/main/starcoin/sources/Base64.move

@jolestar jolestar modified the milestones: Rooch v0.3, Rooch v0.4 Dec 8, 2023
@jolestar jolestar modified the milestones: Rooch v0.5, Rooch v0.6 May 14, 2024
@jolestar jolestar modified the milestones: Rooch v0.6, Rooch v0.7 Jun 3, 2024
@feliciss
Copy link
Collaborator

Use a native function like https://github.com/rooch-network/rooch/blob/f7573bb942b956097e0d1f06a61770ee1f8c60f0/crates/rooch-framework/sources/crypto/decoding.move

Is there a need for implementing the base64 function in Move native functions?

@jolestar jolestar modified the milestones: Rooch v0.7, TBD Aug 10, 2024
@yubing744
Copy link
Collaborator Author

This PR implements Base64 using native functions.

#2553

@github-project-automation github-project-automation bot moved this to Done in Rooch Sep 29, 2024
@jolestar jolestar modified the milestones: TBD, Rooch v0.8 Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yubing744 yubing744

Labels
area:stdlib Move stdlib or framework issues help wanted Extra attention is needed skill::move Need the Move language skill to complete the issue skill::rust Need the rust language skill to complete the issue
Projects
Rooch
Status: Done
Milestone
Rooch v0.8
Development

No branches or pull requests
3 participants
@jolestar @yubing744 @feliciss