[Indexer] Optmize indexer query with timeout and Support Rocksdb metrics #2425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baichuan3
requested review from
popcnt1,
jolestar and
steelgeek091
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
jolestar
approved these changes
Aug 13, 2024
Comment on lines
+118
to
+132
| tokio::task::block_in_place(|| { | ||
| Handle::current().block_on(async move { | ||
| timeout( | ||
| timeout_duration, | ||
| tokio::task::spawn_blocking(move || { | ||
| connection | ||
| .deref_mut() | ||
| .transaction(query) | ||
| .map_err(|e| IndexerError::SQLiteReadError(e.to_string())) | ||
| }), | ||
| ) | ||
| .await | ||
| .map_err(|e| IndexerError::SQLiteAsyncReadError(e.to_string()))?? | ||
| }) | ||
| }) |
There was a problem hiding this comment.
这一部分代码后面可以通过 ActorContext::spawn 放到一个单独的 actor 去执行，这样就不会 block indexer_reader actor 的线程。不过返回值如何获取需要设计一下。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #2366 and part of #1717
runtime execution dependency problem in the test cases and enable rocksdb metrics