Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rooch account sign command #2431

Merged
merged 6 commits into from
Aug 14, 2024
Merged

Conversation

v1xingyue
Copy link
Contributor

Summary

Add rooch account sign command

Copy link

vercel bot commented Aug 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rooch-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2024 5:22am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
rooch ⬜️ Ignored (Inspect) Visit Preview Aug 14, 2024 5:22am

Copy link
Contributor

@jolestar jolestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merge this PR first; the account sign command needs an integration test and support sign tx.

@jolestar jolestar merged commit 939b748 into rooch-network:main Aug 14, 2024
7 checks passed
@jolestar
Copy link
Contributor

part of #2381

@v1xingyue v1xingyue deleted the patch-signer branch August 15, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants