Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gh-2478] add tx submit command. #2479

Merged
merged 3 commits into from
Aug 23, 2024
Merged

Conversation

feliciss
Copy link
Collaborator

@feliciss feliciss commented Aug 20, 2024

Summary

Add tx submit command to submit the signed tx to Rooch.

Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rooch-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2024 9:07am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
rooch ⬜️ Ignored (Inspect) Visit Preview Aug 23, 2024 9:07am

@@ -67,6 +67,7 @@ Feature: Rooch CLI integration tests
# transaction
Then cmd: "transaction get-transactions-by-order --cursor 0 --limit 1 --descending-order false"
Then cmd: "transaction get-transactions-by-hash --hashes {{$.transaction[-1].data[0].execution_info.tx_hash}}"
Then cmd: "transaction submit --signed-tx-hex {{$.transaction[-1]}}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need an assert

Copy link
Collaborator Author

@feliciss feliciss Aug 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need an assert

Resolved. Should #2477 be merged, I'll rebase this PR and merge this.

@jolestar jolestar merged commit 49f5a7b into rooch-network:main Aug 23, 2024
7 checks passed
@feliciss feliciss deleted the #2478 branch August 23, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide rooch tx submit to submit the signed tx to rooch.
2 participants