[bitcoin-move][breaking]Refactor ordinals inscription updater #2500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
jolestar
force-pushed
the
refactor_ordinals
branch
from
e786010
to
2533dda
Compare
baichuan3
reviewed
Aug 25, 2024
| //let input = vector::borrow(txinput, input_idx); | ||
| let utxo = vector::borrow_mut(input_utxos, input_idx); | ||
| if (is_coinbase){ | ||
| total_input_value = total_input_value + ord::subsidy_by_height(block_height); |
There was a problem hiding this comment.
如果是 coinbase 交易，应该在累加 total_input_value后continue，继续循环执行，对应的 utxo为 null utxo
baichuan3
reviewed
Aug 25, 2024
| new: option::some(FlotsamNew{ | ||
| cursed: option::is_some(&curse) && !jubilant, | ||
| fee: 0, | ||
| //TODO should we handle the hidden |
There was a problem hiding this comment.
hidden 字段和home_inscription没有特别看明白，不过看inscriptions_updater.rs实现，貌似对offset没有影响
baichuan3
reviewed
Aug 25, 2024
| let output = vector::borrow(txoutput, output_idx); | ||
| let value = types::txout_value(output); | ||
| let output_script_buf = types::txout_script_pubkey(output); | ||
| let is_op_return = script_buf::is_op_return(output_script_buf); |
There was a problem hiding this comment.
ordinal原始实现里没有处理 op_return
baichuan3
reviewed
Aug 25, 2024
| break | ||
| }; | ||
|
|
||
| let new_satpoint = ord::new_satpoint(types::new_outpoint(txid, (output_idx as u32)), flotsam.offset - output_value); |
There was a problem hiding this comment.
new_satpoint的计算比较复杂，看了几遍，总觉得跟 ordinal 实现有差异，需要测试用例覆盖
jolestar
force-pushed
the
refactor_ordinals
branch
from
f8c4e69
to
45857ee
Compare
jolestar
requested review from
wow-sven,
geometryolife and
pause125
as code owners
jolestar
changed the title
popcnt1
reviewed
Aug 25, 2024
| sequence_number: src.sequence_number, | ||
| inscription_number: src.inscription_number.unsigned_abs(), | ||
| is_curse: src.inscription_number.is_negative(), | ||
| //TODO how to get charms |
There was a problem hiding this comment.
For statedb/genesis: could export charms from ordinal index
popcnt1
reviewed
Aug 25, 2024
| @@ -136,6 +143,9 @@ pub(crate) fn create_genesis_inscription_store_object( | |||
| let inscription_store = InscriptionStore { | |||
| cursed_inscription_count, | |||
| blessed_inscription_count, | |||
| //TODO set unbound_inscription_count and lost_sats | |||
| unbound_inscription_count: 0, | |||
| lost_sats: 0, | |||
There was a problem hiding this comment.
For statedb/genesis: count lost_sats by charm flag
There was a problem hiding this comment.
The ordinals has a statistic_to_count db to get the counts https://github.com/ordinals/ord/blob/75bf04b22107155f8f8ab6c77f6eefa8117d9ace/src/index/updater.rs#L604-L626
popcnt1
approved these changes
Aug 25, 2024
This was referenced Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
copyanddropto SimpleMap and SimpleMultiMap.part of #2402 and #2403