[Move] [break] Support TypeTag and StructTag to canonical string with prefix #2515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baichuan3
requested review from
jolestar,
wow-sven,
popcnt1 and
steelgeek091
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
jolestar
reviewed
Aug 27, 2024
| let test_type_tag = TypeTag::from_str(type_tag_str)?; | ||
| assert_eq!(type_tag_str, test_type_tag.to_string()); | ||
| assert_eq!(type_tag_canonical_str, test_type_tag.to_canonical_string()); | ||
| Ok(()) | ||
| } | ||
|
|
||
| #[test] | ||
| fn test_strange_format_type_tag() -> Result<()> { | ||
| let type_tag_str = "0x900f053234b0ba66ad062b277896b28e049f2813d388da375efcd54b6e429dbe::coin::Coin<0000000000000000000000000000000000000000000000000000000000000003::gas_coin::GasCoin>"; |
There was a problem hiding this comment.
This is an invalid type_tag_str, we do not need to support it.
popcnt1
approved these changes
Aug 28, 2024
jolestar
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TypeTag,StructTagandAccountAddressto canonical string with prefix0x.0x00000000000000000000000000000001::string::Stringor0x0000000000000000000000000000000a::module_name1::type_name1<0x0000000000000000000000000000000a::module_name2::type_name2<u64>>Other impacts include possible break of SDK and front-end applications, please confirm @wow-sven
to_canonical_string()method of TypeTag, StructTag and AccountAddress returns a prefix containing 0x by default