feat: add utxo timelock weight and update coin name #2697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx819812523
requested review from
jolestar,
wow-sven and
geometryolife
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
jolestar
reviewed
Sep 26, 2024
| return 1 | ||
| }; | ||
| let transaction = option::destroy_some(option_tx); | ||
| let tx_lock_time = tx_lock_time(&transaction); |
There was a problem hiding this comment.
The lock_time needs to distinguish between the absolute time and relative time.
jolestar
approved these changes
Sep 26, 2024
| return 1 + u64::min(tx_lock_day, MaxLockDay) | ||
| }; | ||
| // lock_time is a bitcoin time | ||
| // TODO here should be btc time or rooch time? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summary about this PR