[cli] Add Task Scheduling Command and Refactor Wallet Context API #2704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jolestar
requested review from
pause125,
baichuan3 and
wow-sven
as code owners
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
jolestar
commented
Sep 27, 2024
Comment on lines
+162
to
+168
| //TODO FIXME we should use the state_root from previous tx | ||
| let state_root = tx_execution_result | ||
| .execution_info | ||
| .state_root | ||
| .0 | ||
| .as_bytes() | ||
| .to_vec(); |
There was a problem hiding this comment.
@steelgeek091 We use a wrong state_root to execute_tx locally.
There was a problem hiding this comment.
We getting the last Tx order which has been processed by sequencer then use this Tx order to query previous Tx?
There was a problem hiding this comment.
If the tx has been executed and you use the state_root to execute it again, the ObjectID and Resource may conflict. Maybe the gas profile mode should only execute the tx off-chain.
jolestar
changed the title
baichuan3
reviewed
Sep 28, 2024
|
|
||
| #[async_trait] | ||
| impl CommandAction<String> for ScheduleCommand { | ||
| async fn execute(self) -> RoochResult<String> { |
There was a problem hiding this comment.
目前实现的是单节点下的Schedule执行，多节点后再考虑去中心化的Schedule？
There was a problem hiding this comment.
Schedule 的应用场景就是单机模式的定时任务。一般应用自己运行一个就行。去中心化的任务系统需要新的协议来搞。
baichuan3
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces several enhancements and new features: