-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create "subset-by-point" capability #105
Comments
Level and temporal subsetting by point in roocsRequirementAt present, the user can only select times or levels by giving a range: We want to add the ability to specify subsetting by-point, such as:
ConcernsThis needs to be implemented in
ConstraintsThis change will apply to: This change will not apply to: ImplementationImplementing subset-by-levelThe
Implementing subset-by-timeThe
Exception handlingUnsorted input list
Invalid value provided
Repeated value(s)
|
@cehbrecht: Please review and let me know if any of the above doesn't make sense. Thanks |
Here are the affected modules/notebooks:
|
Maybe we need something like:
Or maybe it could just be a property of the Parameter class, i.e. |
Looking at ISO-8601 standard for date/time and intervals. Available libraries: The extension of ISO-8601 also supports "seasons" using special month values, like 21 for spring season: The official ISO-8601 spec is unfortunately not public. The ISO approach does not seem to fit for us. I would like to keep only the
Or using a special notation?:
|
More thoughts about selecting times from
|
@cehbrecht Let's discuss this when we chat. I had assumed we would extend the interface to support "year", "month" and "day" as parameters - but maybe we can push them all through "time" (in some clever way). |
Ideas:
This might work for
What should our separator be? |
Another iteration on the time parameter. For
For time divisions it is a bit tricky. A name for the parameter could be:
The preferred syntax would be like this:
When using WPS We only use To get around this issue we can use double-encoding of the
The value is correctly decoded by We can add a helper function to If we want to avoid double-encoding but keep the "intuitive" syntax we need to add more wps parameters:
|
I'm still quite fond of:
|
Our final decision was:
|
@huard @Zeitsperre @aulemahal @tlogan2000: I am just tagging you all regarding updates we are making to the However, once all in place, you shouldn't see any changes to the The summary of changes is in the cell above (#105 (comment)). |
Could we use a python |
Create "subset-by-point" capability in the roocs stack. This is split into these issues:
See below for the overview of the plan.
The text was updated successfully, but these errors were encountered: