Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of static file handler #40

Merged
merged 1 commit into from
Dec 5, 2021
Merged

Implementation of static file handler #40

merged 1 commit into from
Dec 5, 2021

Conversation

dongxuny
Copy link
Contributor

@dongxuny dongxuny commented Dec 5, 2021

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2021

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 67.34694% with 64 lines in your changes missing coverage. Please review.

Project coverage is 83.42%. Comparing base (3b4f4cb) to head (e198768).
Report is 157 commits behind head on master.

Files with missing lines Patch % Lines
boot/static_file_handler_entry.go 74.85% 33 Missing and 9 partials ⚠️
boot/grpc_entry.go 24.13% 18 Missing and 4 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   84.27%   83.42%   -0.85%     
==========================================
  Files          38       39       +1     
  Lines        3713     3909     +196     
==========================================
+ Hits         3129     3261     +132     
- Misses        456      507      +51     
- Partials      128      141      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dongxuny dongxuny merged commit 6ddac68 into rookie-ninja:master Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants