Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Refactoring based on rk-entry/v2 #59

Merged
merged 1 commit into from
Mar 5, 2022

Conversation

dongxuny
Copy link
Contributor

@dongxuny dongxuny commented Mar 5, 2022

No description provided.

@gitguardian
Copy link

gitguardian bot commented Mar 5, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
- Elliptic Curve Private Key 0218635 example/boot/full/server-key.pem View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@codecov-commenter
Copy link

Codecov Report

Merging #59 (0218635) into master (0b6ef15) will decrease coverage by 1.95%.
The diff coverage is 91.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
- Coverage   90.36%   88.41%   -1.96%     
==========================================
  Files          19       19              
  Lines        1661     1467     -194     
==========================================
- Hits         1501     1297     -204     
- Misses        131      141      +10     
  Partials       29       29              
Impacted Files Coverage Δ
boot/error/grpc_error_wrap.go 100.00% <ø> (ø)
middleware/common.go 96.51% <ø> (ø)
middleware/context/wrappers.go 66.66% <ø> (ø)
middleware/cors/interceptor.go 100.00% <ø> (ø)
middleware/csrf/interceptor.go 100.00% <ø> (ø)
middleware/secure/interceptor.go 100.00% <ø> (ø)
boot/proxy_entry.go 62.44% <77.27%> (-0.35%) ⬇️
boot/grpc_entry.go 87.19% <88.43%> (-5.12%) ⬇️
boot/gw_server_options.go 90.16% <100.00%> (-0.24%) ⬇️
middleware/auth/server_interceptor.go 94.73% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b6ef15...0218635. Read the comment docs.

@dongxuny dongxuny merged commit 11f66bd into rookie-ninja:master Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants