[RF] Deprecate some RooDataSet constructors #14317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Starting build on |
|
Build failed on ROOT-ubuntu2204/nortcxxmod. Failing tests: |
|
Build failed on ROOT-performance-centos8-multicore/soversion. Errors:
Failing tests:
|
|
Build failed on windows10/default. Failing tests: |
|
Build failed on ROOT-ubuntu2004/python3. Failing tests: |
Avoid using some redundant RooDataSet constructors that will be deprecated.
Avoid using some redundant RooDataSet constructors that will be deprecated. Separate commit from the previous one so it can be backported.
When using the `RooFit::Cut("...")` command argument in the RooDataSet
constructor to filter imported datasets, the `RooFormulaVar`
representing the cut should not check if all the variables in the
dataset are used for the expression.
This is already done in other code branches like the
`RooVectorDataStore` constructors, and this commit adds this tweak also
to the remaining `RooDataSet` constructors to make the behavior
consistent.
The RooDataSet has some constructors that are redundant with specific cases that can be covered with the command-argument constructor. This can cause confusion like here in the forum: https://root-forum.cern.ch/t/how-to-use-weighted-unbinned-dataset-in-roofit/57631 To avoid this interface duplication, these constructors are deprecated and will be removed in ROOT 6.34.
The correct signature is `RooFit::Import(TTree&)`. This was noticed thanks to the following forum post. https://root-forum.cern.ch/t/how-to-use-weighted-unbinned-dataset-in-roofit/57631
|
Starting build on |
guitargeek
requested review from
couet,
lmoneta,
hageboeck,
Axel-Naumann and
vepadulano
as code owners
Test Results 9 files 9 suites 1d 22h 14m 9s ⏱️ Results for commit d3086d4. |
guitargeek
changed the title
guitargeek
added a commit
to guitargeek/HiggsAnalysis-CombinedLimit
that referenced
this pull request
Apr 17, 2024
The RooDataSet constructor that takes a weight variable name was deprecated in ROOT 6.32: root-project/root#14317 The general command argument constructor should be used, which doesn't change the functionality and is also backwards compatible with older ROOT versions. Also, avoid a unused variable warning.
guitargeek
added a commit
to guitargeek/HiggsAnalysis-CombinedLimit
that referenced
this pull request
Apr 18, 2024
The RooDataSet constructor that takes a weight variable name was deprecated in ROOT 6.32: root-project/root#14317 The general command argument constructor should be used, which doesn't change the functionality and is also backwards compatible with older ROOT versions. Also, avoid a unused variable warning.
kcormi
added a commit
to kcormi/HiggsAnalysis-CombinedLimit
that referenced
this pull request
Jun 24, 2024
The RooDataSet constructor that takes a weight variable name was deprecated in ROOT 6.32: root-project/root#14317 The general command argument constructor should be used, which doesn't change the functionality and is also backwards compatible with older ROOT versions. Also, avoid a unused variable warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other constructors can cause some confusion to the users.
For now, this change is only to see the result of the CI.