Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty Taskplan params #132

Closed
michael-smith-nz opened this issue Aug 15, 2017 · 2 comments
Closed

Empty Taskplan params #132

michael-smith-nz opened this issue Aug 15, 2017 · 2 comments
Labels

Comments

@michael-smith-nz
Copy link
Member

Logging issue because I'm going down a rabbit hole.

Is it possible to have an empty params property on taskPlan?
This getter is currently breaking order creation.
Happy to fix, but needed to know the above question first.

const { contextAgentId } = params

@ahdinosaur
Copy link
Member

Is it possible to have an empty params property on taskPlan?

yes! probably best if we coerce undefined and null into {}, but it's definitely possible to have an empty object for params.

This getter is currently breaking order creation

yeah, the "order pre-req" tasks expect params.contextAgentId, so we know how to update the group profile and invite group members. but others tasks, say like the "setup your personal profile" task don't need this context agent.

@michael-smith-nz
Copy link
Member Author

Turns out the problem with the broken order creation getter was that params was not writing to the database because we were not encoding the object as a string before writing. Should be fixed in abd1248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants