Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend to create all the respective objects and relations on order start #116

Merged
merged 16 commits into from
Jul 26, 2017

Conversation

gregorykan
Copy link
Contributor

No description provided.

@gregorykan gregorykan changed the title finish prereqs flow backend to create all the respective objects and relations on order start Jul 25, 2017
@gregorykan gregorykan requested a review from ahdinosaur July 25, 2017 05:47

}

Profile.propTypes = {
Copy link

@danalexilewis danalexilewis Jul 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gregorykan whats the thinking around proptypes? are we not going to use them at all?

and @ahdinosaur I am still curious and keen on an implementation of types on the apis of modules. Is the thinking that components shouldn't have a type api?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we've decided to not use them. but also still keen on a type api, just haven't made it a priority in our sprints to add type schemas, which maybe we should do.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here's an issue for this meow: #118


}

Profile.propTypes = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we've decided to not use them. but also still keen on a type api, just haven't made it a priority in our sprints to add type schemas, which maybe we should do.

@ahdinosaur ahdinosaur merged commit 0001349 into master Jul 26, 2017
@ahdinosaur ahdinosaur removed the review label Jul 26, 2017
@ahdinosaur ahdinosaur added this to the sprint 3 milestone Jul 26, 2017
@ahdinosaur ahdinosaur modified the milestones: sprint 3, beta 1 Aug 15, 2017
@ahdinosaur ahdinosaur removed this from the sprint 3 milestone Aug 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants