-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backend to create all the respective objects and relations on order start #116
Conversation
- defensive against undefined agent or profile - pure functional component - uses hyperscript
…igration to fix assigneeId column on taskPlans table
|
||
} | ||
|
||
Profile.propTypes = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gregorykan whats the thinking around proptypes? are we not going to use them at all?
and @ahdinosaur I am still curious and keen on an implementation of types on the apis of modules. Is the thinking that components shouldn't have a type api?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we've decided to not use them. but also still keen on a type api, just haven't made it a priority in our sprints to add type schemas, which maybe we should do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here's an issue for this meow: #118
|
||
} | ||
|
||
Profile.propTypes = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we've decided to not use them. but also still keen on a type api, just haven't made it a priority in our sprints to add type schemas, which maybe we should do.
No description provided.