Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Menubar Icon rendering as black circle #148

Open
fogdogit-paul-s opened this issue Sep 27, 2023 · 4 comments
Open

Custom Menubar Icon rendering as black circle #148

fogdogit-paul-s opened this issue Sep 27, 2023 · 4 comments
Assignees
Labels
wontfix This will not be worked on

Comments

@fogdogit-paul-s
Copy link

Hi - trying to get a custom menubar icon configured however it keeps rendering as a black circle (my icon is a circle). It looks like the below:
Screenshot 2023-09-27 at 11 27 23

Interestingly, if I use an icon like this it works:
customer-support
Here is the logo I am using:
fdit_menubar_color_16

I have made sure the image is resize to 19 points per your documentation - my attempts to ascertain the difference between the working test logo and my logo have come up with nothing (I have converted to grayscale and b&w).

If you could help shed some light on this I would be very grateful!

thanks

@jordywitteman
Copy link
Contributor

Hi @fogdogit-paul-s, please refer to the documentation here: https://github.com/root3nl/SupportApp#menu-bar-icon

The menu bar icon is marked as a template (grayscale) to get the native macOS look and feel. So in this case the icon is a filled circle and that results (as expected) in a solid image, dark or light depending on the wallpaper and light/dark mode status. We deliberately developed it this way to avoid clutter by allowing non-native colors to be shown in the menu bar.

However, I will keep this one open, because we have seen like 5+ same requests on GitHub in the past and some admins have forked the project, disabled the template option and compiled it themselves. Will think about this by perhaps optionally allowing this to be disabled if many people upvote.

@jordywitteman jordywitteman added the enhancement New feature or request label Sep 27, 2023
@jordywitteman jordywitteman self-assigned this Sep 27, 2023
@fogdogit-paul-s
Copy link
Author

fogdogit-paul-s commented Sep 27, 2023

Thanks Jordy - thanks but I am afraid I don't totally follow you (mostly due to my lack of comprehension!) I don't totally understand what you mean by "marked as a template"! Is there any way for me to get my company logo to present here - what do I need to do to the PNG to have it show?

For example - how did you get the icon shown here to display:

Screenshot 2023-09-27 at 15 33 52

@jordywitteman
Copy link
Contributor

Hi @fogdogit-paul-s

It is very well explained here how the menu bar icons work and should work (according to Apple) and that is how is works in the app as well: https://bjango.com/articles/designingmenubarextras/#colour-and-template-images

In general, everything in the image which has no opacity at all using the alpha channel, is converted to just solid black or white. The example you are referring to, is basically a shape with leaves, your image is a circle and that results into a circle shape. So to be very clear, it is currently not possible to show your image in the menu bar with all colors included, because of the Apple guidelines we follow and is by design.

@fogdogit-paul-s
Copy link
Author

fogdogit-paul-s commented Sep 29, 2023 via email

@jordywitteman jordywitteman added wontfix This will not be worked on and removed enhancement New feature or request labels Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants