use docker idtools for subid lookups #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, could you sign your commit with your real name ( |
…lookups Signed-off-by: Jared Bancroft <jaredb@broadinstitute.org>
jaredbancroft
force-pushed
the
jb_idtools
branch
from
36d945c
to
e2a5df0
Compare
|
All set |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runc/libcontainer/user lookups depend on users being local to the system and appearing in /etc/passwd and /etc/group. docker idtools fall back to using getent if local users aren't present which allows external lookups to work (systems using ldap with sssd). idtools looks up both subuid and subgid in a single map command which fails if a users primary group does not have the same name as their username, so username is passed as both arguments to idtools.NewIdentityMapping. os/user is used to determine uid and primary gid.