seccomp: do not fail on error from seccomp_arch_add() #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AkihiroSuda How can I get an RPM to install with this new change? Is there a script? |
|
I see this: https://github.com/containers/podman/blob/master/contrib/build_rpm.sh I will try |
|
I don't know how to build RPM, but you can install slirp4netns from the source: https://github.com/rootless-containers/slirp4netns#install-from-source |
This one seems for Podman, not for slirp4netns |
|
@AkihiroSuda I thought it bundled both but probably not you're right. |
|
Works, full log: If I run: This confirms that this PR fixes the issue. |
|
Thanks, could you also try https://github.com/rootless-containers/slirp4netns#usage but with I want to know the output of the newly added |
And network access works in the namespace |
|
Thank, but the |
|
Sorry please try this diff --git a/seccompfilter.c b/seccompfilter.c
index 3de6b95..edd3cfb 100644
--- a/seccompfilter.c
+++ b/seccompfilter.c
@@ -20,7 +20,7 @@ int enable_seccomp()
if (rc < 0 && rc != -EEXIST) {
fprintf(stderr,
"seccomp: WARNING: can't add extra arch (i=%d): %s\n", i,
- strerror(errno));
+ strerror(-rc));
}
}
printf("seccomp: The following syscalls will be blocked by seccomp:"); |
|
|
Thanks, never heard of this errno 👀 > |
|
@AkihiroSuda Me neither. |
Especially ignore EDOM on ppc64le Fix containers/podman#6922 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix containers/podman#6922