Store display_sidebar in static variable #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| return apply_filters('roots/display_sidebar', $sidebar_config->display); | ||
| if(!isset($display)) { |
There was a problem hiding this comment.
space after if to match the rest of the codebase
|
Rebased. |
retlehs
added a commit
that referenced
this pull request
Nov 12, 2014
Store display_sidebar in static variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for users who might call this function more than once for whatever reason. It ensures that each return from the function is always the same value (so if you hook into the filter, do it before an initial call to
roots_display_sidebar()).In addition to that practical benefit, this is also more performant in that each call to the function will no longer create a new
Roots_Sidebarobject, nor will each call to the function run the callbacks for'roots/display_sidebar'; these will only be done on the initial call to the function to populate the value of the static variable.