Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ansible 2.7 compatibility #1045

Merged
merged 1 commit into from
Dec 14, 2018
Merged

Ansible 2.7 compatibility #1045

merged 1 commit into from
Dec 14, 2018

Conversation

retlehs
Copy link
Member

@retlehs retlehs commented Dec 14, 2018

updated the connection role to account for this change in ansible versions:

2.5: [0;32m "\u001b[0;32mroot", [0m
2.7: [0;32m "\u001b[0;33mroot", [0m

props @swalkinshaw

close #1041

@swalkinshaw
Copy link
Member

The difference in output is due to a different colour used by success or changed status. We have changed_when: false on the task but maybe that isn't making it return "success" anymore.

So in 2.6 or 2.7, the task now reports as changed which changes the colour output.

We should ideally try and find a less brittle way of determining if root can connect if possible although I know @fullyint did a lot of work on this so maybe there isn't really.

@retlehs retlehs merged commit 42eb0b9 into master Dec 14, 2018
@retlehs retlehs deleted the bump-ansible-ver branch December 14, 2018 02:56
@swalkinshaw swalkinshaw mentioned this pull request Dec 14, 2018
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade vagrant_ansible_version?
2 participants