-
-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WP-CLI bash completion script #407
Conversation
7fce952
to
5d37d98
Compare
@@ -1,2 +1,4 @@ | |||
phar_url: https://raw.githubusercontent.com/wp-cli/builds/gh-pages/phar/wp-cli.phar | |||
bin_path: /usr/bin/wp | |||
wp_cli_completion_url: https://raw.githubusercontent.com/wp-cli/wp-cli/master/utils/wp-completion.bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should wait for #392 if we do it since there could be a disconnect between the completion commands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. That's why I splitted it into 2 commits. I don't know why #392 is not merged yet though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We internally debated about whether we should be using a nightly version at all. Because then there's a difference between dev/prod.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. But bash completion is the same for both AFAIK (I think is the the same script since I started using WP-CLI some 2 years ago or so).
Added WP-CLI bash completion script.
I really should have look at the script. Of course it just determines the completions from wp-cli so it will be in sync. Thanks a lot :) |
I'm glad to contribute to this project, sir! 😃 |
This change automatically installs the tab completion script for wp-cli, making it more fun and less error-prone to use.