Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WP-CLI bash completion script #407

Merged
merged 2 commits into from
Nov 11, 2015

Conversation

primozcigler
Copy link
Contributor

This change automatically installs the tab completion script for wp-cli, making it more fun and less error-prone to use.

@@ -1,2 +1,4 @@
phar_url: https://raw.githubusercontent.com/wp-cli/builds/gh-pages/phar/wp-cli.phar
bin_path: /usr/bin/wp
wp_cli_completion_url: https://raw.githubusercontent.com/wp-cli/wp-cli/master/utils/wp-completion.bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should wait for #392 if we do it since there could be a disconnect between the completion commands.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. That's why I splitted it into 2 commits. I don't know why #392 is not merged yet though?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We internally debated about whether we should be using a nightly version at all. Because then there's a difference between dev/prod.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. But bash completion is the same for both AFAIK (I think is the the same script since I started using WP-CLI some 2 years ago or so).

swalkinshaw added a commit that referenced this pull request Nov 11, 2015
Added WP-CLI bash completion script.
@swalkinshaw swalkinshaw merged commit 5dc3b69 into roots:master Nov 11, 2015
@swalkinshaw
Copy link
Member

I really should have look at the script. Of course it just determines the completions from wp-cli so it will be in sync.

Thanks a lot :)

@primozcigler
Copy link
Contributor Author

I'm glad to contribute to this project, sir! 😃

@primozcigler primozcigler deleted the wpcli-completion branch November 26, 2015 22:31
@swalkinshaw swalkinshaw changed the title Added WP-CLI bash completion script. Add WP-CLI bash completion script. Nov 29, 2015
@swalkinshaw swalkinshaw changed the title Add WP-CLI bash completion script. Add WP-CLI bash completion script Nov 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants