Fix #581 - Use WP-CLI to run WP cron #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
swalkinshaw
force-pushed
the
use-wp-cli-for-wp-cron
branch
from
eb8eba9
to
1297c73
Compare
#533 caused a regression in the cron job which runs `wp-cron.php`. Since `wp_home` and `wp_siteurl` were changed to use bash and PHP variables, the cron command wouldn't work. The solution is to avoid this and use WP-CLI's `cron` command for running due cron events.
swalkinshaw
force-pushed
the
use-wp-cli-for-wp-cron
branch
from
1297c73
to
f07bf72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#533 caused a regression in the cron job which runs
wp-cron.php. Sincewp_homeandwp_siteurlwere changed to use bash and PHP variables, the cron command wouldn't work.The solution is to avoid this and use WP-CLI's
croncommand for running due cron events.Note: this can't be merged yet because the
--due-nowfeature is not in the last WP-CLI release so we're waiting on the next one.