Deploys: --skip-themes when updating WP template_root #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Some WP themes may throw errors if loaded in this context, e.g., some PHP classes may not be available with `--skip-plugins`. It is not necessary to load themes when updating WP options for template_root and stylesheet root, so it is safer to `--skip-themes`.
fullyint
force-pushed
the
template-root-skip-themes
branch
from
7f55a1b
to
07ee21e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a piece of the former #848 and addresses https://discourse.roots.io/t/deploy-failing-at-task-deploy-get-wp-theme-template-root/10017
Some WP themes may throw errors if loaded in this context, e.g., some PHP classes may not be available with
--skip-plugins. It is not necessary to load themes when updating WP options fortemplate_rootandstylesheet_root, so it is safer to--skip-themes.Trellis already uses
--skip-themesin conjunction with--skip-pluginsin theWordPress Installed?task.