Disallow duplicate site keys within a host's wordpress_sites #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fullyint
force-pushed
the
validate-site-keys
branch
from
fbf7f11
to
fb588dd
Compare
If a user loads both staging and production sites on a single host, site keys must differ between environments to prevent conflict that would otherwise occur in resources built from site keys (e.g., Nginx conf filepaths).
fullyint
force-pushed
the
validate-site-keys
branch
from
fb588dd
to
6175552
Compare
primozcigler
added a commit
to primozcigler/trellis
that referenced
this pull request
Nov 19, 2017
* tag '1.0.0-rc.2': 1.0.0-rc.2 Update to WP-CLI 1.4.1. Disallow duplicate site keys within a host's wordpress_sites (roots#910) Replace bare Dataloader() with pre-loaded play._loader (roots#917) Remove outdated to_unicode import from plugin utils (roots#916) Fix raw_vars functionality for Ansible 2.4.1 (roots#915) Enable ioapic Update vagrant_box_version to current release
primozcigler
added a commit
to proteusthemes/pt-ops
that referenced
this pull request
Jan 5, 2018
* trellis/master: (292 commits) Bump Ansible version_tested_max to 2.4.2.0 (roots#932) Add MariaDB 10.2 PPA Remove cron_file if WP system cron disabled (roots#927) Add Code of Conduct [ci skip] Expose the deploy_helper keep_releases option (roots#922) Close roots#580 - Switch from .dev to .test Update acme-tiny commit hash Enable select deploy configs to optionally vary by site (roots#919) 1.0.0-rc.2 Update to WP-CLI 1.4.1. Disallow duplicate site keys within a host's wordpress_sites (roots#910) Replace bare Dataloader() with pre-loaded play._loader (roots#917) Remove outdated to_unicode import from plugin utils (roots#916) Fix raw_vars functionality for Ansible 2.4.1 (roots#915) Enable ioapic Update vagrant_box_version to current release Dynamically increase ansible_group_priority for selected env (roots#909) Bump Ansible version_tested_max to 2.4.1.0 (roots#911) Clarify DB task name. Update wp-cli to 1.4.0. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? This PR adds a validation to prevent duplicate site keys when a host is in multiple
envgroups simultaneously. Fixes https://discourse.roots.io/t/10756/2Why? If a user loads a site's staging and production environment on a single host, site keys must differ between environments to prevent conflict that would otherwise occur in resources built from site keys (e.g., Nginx conf filepaths). Loading both production and staging on a single server is discouraged, but at least this PR prevents one of the most certain accompanying problems.
Rarely runs. This validation skips in the usual case that a host is only in a single
envgroup.To disable. Hate it? Have a special case when you don't want the validation? Define
validate_site_keys: false.Custom envs? If people have custom environments and care to have them validated by this PR's procedure, they can redefine
env_groupsingroup_vars/all/main.yml, including their customenvin the list.Shouldn't choke on weird customizations. In case users have customizations such that the
wordpress_sites.ymlfile is missing or thewordpress_sitesdict is missing for anenv, the validation in this PR won't choke with a yaml or jinja failure, but no validation will occur.Loads files manually. Ansible only loads
wordpress_sitesvars from a singleenvgroup on a given playbook run. Thus we must manually load the vars files ourselves in order to accesswordpress_sitesfrom multiple environments simultaneously. Simultaneous access is necessary to check for duplicate site keys.Example error message.