Fix failed_when in template_root check with wp-cli 1.5.0 #948
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous wp-cli versions returned rc=1 and stderr='' for
wp option get template_root
when the option didn't exist. Version 1.5.0 (#944) uses a new stderr message.This PR changes to only failing if stderr is not empty and does not match this new and expected message.
Alternatively, it would probably be fine to simply use
failed_when: false
This PR prevents errors like the following: