forked from cosmos/cosmos-sdk
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: x/authz audit changes (cosmos#14120)
* chore: x/authz audit changes * nits * tests * Update x/authz/keeper/msg_server_test.go Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com> Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com> Co-authored-by: Marko <marbar3778@yahoo.com>
- Loading branch information
3 people
committed
Dec 6, 2022
1 parent
4a7e3f0
commit 8a2c93f
Showing
6 changed files
with
281 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,263 @@ | ||
| package keeper_test | ||
|
|
||
| import ( | ||
| "time" | ||
|
|
||
| simtestutil "github.com/cosmos/cosmos-sdk/testutil/sims" | ||
| sdk "github.com/cosmos/cosmos-sdk/types" | ||
| authtypes "github.com/cosmos/cosmos-sdk/x/auth/types" | ||
| "github.com/cosmos/cosmos-sdk/x/authz" | ||
| banktypes "github.com/cosmos/cosmos-sdk/x/bank/types" | ||
|
|
||
| "github.com/golang/mock/gomock" | ||
| ) | ||
|
|
||
| func (suite *TestSuite) createAccounts(accs int) []sdk.AccAddress { | ||
| addrs := simtestutil.CreateIncrementalAccounts(2) | ||
| suite.accountKeeper.EXPECT().GetAccount(gomock.Any(), suite.addrs[0]).Return(authtypes.NewBaseAccountWithAddress(suite.addrs[0])).AnyTimes() | ||
| suite.accountKeeper.EXPECT().GetAccount(gomock.Any(), suite.addrs[1]).Return(authtypes.NewBaseAccountWithAddress(suite.addrs[1])).AnyTimes() | ||
| return addrs | ||
| } | ||
|
|
||
| func (suite *TestSuite) TestGrant() { | ||
| ctx := suite.ctx.WithBlockTime(time.Now()) | ||
| addrs := suite.createAccounts(2) | ||
| curBlockTime := ctx.BlockTime() | ||
|
|
||
| oneHour := curBlockTime.Add(time.Hour) | ||
| oneYear := curBlockTime.AddDate(1, 0, 0) | ||
|
|
||
| coins := sdk.NewCoins(sdk.NewCoin("steak", sdk.NewInt(10))) | ||
|
|
||
| grantee, granter := addrs[0], addrs[1] | ||
|
|
||
| testCases := []struct { | ||
| name string | ||
| malleate func() *authz.MsgGrant | ||
| expErr bool | ||
| errMsg string | ||
| }{ | ||
| { | ||
| name: "invalid granter", | ||
| malleate: func() *authz.MsgGrant { | ||
| grant, err := authz.NewGrant(curBlockTime, banktypes.NewSendAuthorization(coins, nil), &oneYear) | ||
| suite.Require().NoError(err) | ||
| return &authz.MsgGrant{ | ||
| Granter: "invalid", | ||
| Grantee: grantee.String(), | ||
| Grant: grant, | ||
| } | ||
| }, | ||
| expErr: true, | ||
| errMsg: "invalid bech32 string", | ||
| }, | ||
| { | ||
| name: "invalid grantee", | ||
| malleate: func() *authz.MsgGrant { | ||
| grant, err := authz.NewGrant(curBlockTime, banktypes.NewSendAuthorization(coins, nil), &oneYear) | ||
| suite.Require().NoError(err) | ||
| return &authz.MsgGrant{ | ||
| Granter: granter.String(), | ||
| Grantee: "invalid", | ||
| Grant: grant, | ||
| } | ||
| }, | ||
| expErr: true, | ||
| errMsg: "invalid bech32 string", | ||
| }, | ||
| { | ||
| name: "grantee account does not exist on chain: valid grant", | ||
| malleate: func() *authz.MsgGrant { | ||
| newAcc := sdk.AccAddress("valid") | ||
| suite.accountKeeper.EXPECT().GetAccount(gomock.Any(), newAcc).Return(nil).AnyTimes() | ||
| acc := authtypes.NewBaseAccountWithAddress(newAcc) | ||
| suite.accountKeeper.EXPECT().NewAccountWithAddress(gomock.Any(), newAcc).Return(acc).AnyTimes() | ||
| suite.accountKeeper.EXPECT().SetAccount(gomock.Any(), acc).Return() | ||
|
|
||
| grant, err := authz.NewGrant(curBlockTime, banktypes.NewSendAuthorization(coins, nil), &oneYear) | ||
| suite.Require().NoError(err) | ||
| return &authz.MsgGrant{ | ||
| Granter: granter.String(), | ||
| Grantee: newAcc.String(), | ||
| Grant: grant, | ||
| } | ||
| }, | ||
| }, | ||
| { | ||
| name: "valid grant", | ||
| malleate: func() *authz.MsgGrant { | ||
| grant, err := authz.NewGrant(curBlockTime, banktypes.NewSendAuthorization(coins, nil), &oneYear) | ||
| suite.Require().NoError(err) | ||
| return &authz.MsgGrant{ | ||
| Granter: granter.String(), | ||
| Grantee: grantee.String(), | ||
| Grant: grant, | ||
| } | ||
| }, | ||
| }, | ||
| { | ||
| name: "valid grant, same grantee, granter pair but different msgType", | ||
| malleate: func() *authz.MsgGrant { | ||
| g, err := authz.NewGrant(curBlockTime, banktypes.NewSendAuthorization(coins, nil), &oneHour) | ||
| suite.Require().NoError(err) | ||
| _, err = suite.msgSrvr.Grant(suite.ctx, &authz.MsgGrant{ | ||
| Granter: granter.String(), | ||
| Grantee: grantee.String(), | ||
| Grant: g, | ||
| }) | ||
| suite.Require().NoError(err) | ||
|
|
||
| grant, err := authz.NewGrant(curBlockTime, authz.NewGenericAuthorization("/cosmos.bank.v1beta1.MsgUpdateParams"), &oneHour) | ||
| suite.Require().NoError(err) | ||
| return &authz.MsgGrant{ | ||
| Granter: granter.String(), | ||
| Grantee: grantee.String(), | ||
| Grant: grant, | ||
| } | ||
| }, | ||
| }, | ||
| } | ||
|
|
||
| for _, tc := range testCases { | ||
| suite.Run(tc.name, func() { | ||
| _, err := suite.msgSrvr.Grant(suite.ctx, tc.malleate()) | ||
| if tc.expErr { | ||
| suite.Require().Error(err) | ||
| suite.Require().Contains(err.Error(), tc.errMsg) | ||
| } else { | ||
| suite.Require().NoError(err) | ||
| } | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| func (suite *TestSuite) TestRevoke() { | ||
| addrs := suite.createAccounts(2) | ||
|
|
||
| grantee, granter := addrs[0], addrs[1] | ||
|
|
||
| testCases := []struct { | ||
| name string | ||
| malleate func() *authz.MsgRevoke | ||
| expErr bool | ||
| errMsg string | ||
| }{ | ||
| { | ||
| name: "invalid granter", | ||
| malleate: func() *authz.MsgRevoke { | ||
| return &authz.MsgRevoke{ | ||
| Granter: "invalid", | ||
| Grantee: grantee.String(), | ||
| MsgTypeUrl: bankSendAuthMsgType, | ||
| } | ||
| }, | ||
| expErr: true, | ||
| errMsg: "invalid bech32 string", | ||
| }, | ||
| { | ||
| name: "invalid grantee", | ||
| malleate: func() *authz.MsgRevoke { | ||
| return &authz.MsgRevoke{ | ||
| Granter: granter.String(), | ||
| Grantee: "invalid", | ||
| MsgTypeUrl: bankSendAuthMsgType, | ||
| } | ||
| }, | ||
| expErr: true, | ||
| errMsg: "invalid bech32 string", | ||
| }, | ||
| { | ||
| name: "valid grant", | ||
| malleate: func() *authz.MsgRevoke { | ||
| suite.createSendAuthorization(grantee, granter) | ||
|
|
||
| return &authz.MsgRevoke{ | ||
| Granter: granter.String(), | ||
| Grantee: grantee.String(), | ||
| MsgTypeUrl: bankSendAuthMsgType, | ||
| } | ||
| }, | ||
| }, | ||
| { | ||
| name: "no existing grant to revoke", | ||
| malleate: func() *authz.MsgRevoke { | ||
| return &authz.MsgRevoke{ | ||
| Granter: granter.String(), | ||
| Grantee: grantee.String(), | ||
| MsgTypeUrl: bankSendAuthMsgType, | ||
| } | ||
| }, | ||
| expErr: true, | ||
| errMsg: "authorization not found", | ||
| }, | ||
| } | ||
|
|
||
| for _, tc := range testCases { | ||
| suite.Run(tc.name, func() { | ||
| _, err := suite.msgSrvr.Revoke(suite.ctx, tc.malleate()) | ||
| if tc.expErr { | ||
| suite.Require().Error(err) | ||
| suite.Require().Contains(err.Error(), tc.errMsg) | ||
| } else { | ||
| suite.Require().NoError(err) | ||
| } | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| func (suite *TestSuite) TestExec() { | ||
| addrs := suite.createAccounts(2) | ||
|
|
||
| grantee, granter := addrs[0], addrs[1] | ||
| coins := sdk.NewCoins(sdk.NewCoin("steak", sdk.NewInt(10))) | ||
|
|
||
| msg := &banktypes.MsgSend{ | ||
| FromAddress: granter.String(), | ||
| ToAddress: grantee.String(), | ||
| Amount: coins, | ||
| } | ||
|
|
||
| testCases := []struct { | ||
| name string | ||
| malleate func() authz.MsgExec | ||
| expErr bool | ||
| errMsg string | ||
| }{ | ||
| { | ||
| name: "invalid grantee", | ||
| malleate: func() authz.MsgExec { | ||
| return authz.NewMsgExec(sdk.AccAddress{}, []sdk.Msg{msg}) | ||
| }, | ||
| expErr: true, | ||
| errMsg: "empty address string is not allowed", | ||
| }, | ||
| { | ||
| name: "no existing grant", | ||
| malleate: func() authz.MsgExec { | ||
| return authz.NewMsgExec(grantee, []sdk.Msg{msg}) | ||
| }, | ||
| expErr: true, | ||
| errMsg: "authorization not found", | ||
| }, | ||
| { | ||
| name: "valid case", | ||
| malleate: func() authz.MsgExec { | ||
| suite.createSendAuthorization(grantee, granter) | ||
| return authz.NewMsgExec(grantee, []sdk.Msg{msg}) | ||
| }, | ||
| }, | ||
| } | ||
|
|
||
| for _, tc := range testCases { | ||
| suite.Run(tc.name, func() { | ||
| req := tc.malleate() | ||
| _, err := suite.msgSrvr.Exec(suite.ctx, &req) | ||
| if tc.expErr { | ||
| suite.Require().Error(err) | ||
| suite.Require().Contains(err.Error(), tc.errMsg) | ||
| } else { | ||
| suite.Require().NoError(err) | ||
| } | ||
| }) | ||
| } | ||
| } |