Skip to content
This repository has been archived by the owner on Sep 9, 2022. It is now read-only.

ft_get problem: when passing in ft_links output when bad urls #173

Closed
sckott opened this issue Oct 2, 2018 · 1 comment
Closed

ft_get problem: when passing in ft_links output when bad urls #173

sckott opened this issue Oct 2, 2018 · 1 comment
Labels
Milestone

Comments

@sckott
Copy link
Contributor

sckott commented Oct 2, 2018

related crminer issue ropensci-archive/crminer#28

on cache-clean branch but should be broken on master as well:

res2 <- ft_search(query = 'ecology', from = 'crossref', limit = 3)
out <- ft_links(res2)
ft_get(x = out, type = "pdf")
#> Error in private$crul_h_pool[[z]] <- handle :
#>   wrong args for environment subassignment
#> In addition: Warning message:
#> In if (!grepl("https?://", x)) stop("Not a proper url") else x :
#>   the condition has length > 1 and only the first element will be used
@sckott sckott added the bug label Oct 2, 2018
@sckott sckott added this to the v1.1.0 milestone Oct 2, 2018
@sckott
Copy link
Contributor Author

sckott commented Oct 2, 2018

there's two urls for a single article, each of which has unspecified type, so I think that's the problem is we're passing 2 urls to a function that expects 1

sckott added a commit that referenced this issue Oct 3, 2018
depends on dev version of crminer that has a fix in crm_links
@sckott sckott closed this as completed in 87025a6 Oct 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant