Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add r release build #31

Merged
merged 2 commits into from
Feb 4, 2020
Merged

add r release build #31

merged 2 commits into from
Feb 4, 2020

Conversation

annakrystalli
Copy link
Contributor

This build will test whether manual instructions are sufficient to install all dependencies locally (for reviewers and collaborators)

Related to ropensci/software-review#359 (comment)

This build will test whether manual instructions are sufficient to install all dependencies locally (for reviewers and collaborators)
@llrs llrs merged commit 5c95ce2 into ropensci:master Feb 4, 2020
@annakrystalli
Copy link
Contributor Author

Hello @llrs ! Sorry, I don't think the checks have finished. I'm not sure that this setup work yet 😬

@annakrystalli
Copy link
Contributor Author

All good, it seems to have worked successfully! Phew!

Does the reason behind it make sense to you? With this set up, if you do end up adding a dependency that needs special installation, the r release build should notify you.

@llrs
Copy link
Member

llrs commented Feb 4, 2020

Yes, I merged ahead of the checks. It makes sense to test more on the repository, to be sure that user are able to install the packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants