Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errors rework for new setup #242

Closed
sckott opened this issue Dec 28, 2018 · 1 comment
Closed

errors rework for new setup #242

sckott opened this issue Dec 28, 2018 · 1 comment
Milestone
v1.0

Comments

@sckott
Copy link
Contributor

sckott commented Dec 28, 2018

https://github.com/ropensci/elastic/blob/r6-conn/R/Elasticsearch.R#L121 here we set the errors user preference as an env var, but this would then overwrite an error preference for another connection object. Make this justs a var in the object itself, and here https://github.com/ropensci/elastic/blob/r6-conn/R/httr-verbs.R#L151 use the conn object error var - will require that we pass conn object to geterror() calls
@sckott sckott added this to the v1.0 milestone Dec 28, 2018
@sckott
Copy link
Contributor Author

sckott commented Dec 28, 2018

related to #87

sckott added a commit that referenced this issue Mar 11, 2019
@sckott
fix #242 errors choice now a param value in connection object
7ed5fdf 
pass connection object to geterror() now throughout pkg
@sckott sckott closed this as completed Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
1 participant
@sckott