Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No result returned by Search if type contains special characters #49

Closed
arnauldvm opened this issue Feb 18, 2015 · 2 comments
Closed

No result returned by Search if type contains special characters #49

arnauldvm opened this issue Feb 18, 2015 · 2 comments
Assignees
@sckott
Labels
bug
Milestone
v0.4

Comments

@arnauldvm
Copy link 

> type_rp="rp_access+comp_name+protocol"
> ...
> results = Search(index=index, type=type, ...)
(empty results)

Search should URL-encode type:

> type_rp="rp_access%2Bcomp_name%2Bprotocol"
> ...
> results = Search(index=index, type=type, ...)
(14335 hits)
@sckott sckott added the bug label Feb 18, 2015
@sckott sckott self-assigned this Feb 18, 2015
@sckott sckott added this to the v0.4 milestone Feb 18, 2015
sckott added a commit that referenced this issue Feb 18, 2015
@sckott
fixed url encoding for index and type inputs to Search #49
4d562c4 
will do more with remainder of functions to make sure works across pkg
other params passed are passed in query via httr fxns which urlencode for us
@sckott
Copy link
Contributor

sckott commented Feb 18, 2015

@arnauldvm okay, try again after reinstalling

haven't fixed yet across the pkg, but Search() should work now

sckott added a commit that referenced this issue Feb 18, 2015
@sckott
changed remainder of internal fxns to escape index and type inputs #49
254ae58
@sckott
Copy link
Contributor

sckott commented Feb 18, 2015

closing this as should be fine now, reopen if still not fixed

@sckott sckott closed this as completed Feb 18, 2015
@sckott sckott mentioned this issue Aug 15, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sckott sckott

Labels
bug
Projects
None yet
Milestone
v0.4
Development

No branches or pull requests
2 participants
@arnauldvm @sckott