Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding information about user and password for ES with X-Pack #185

Merged
merged 1 commit into from
Jul 11, 2017

Conversation

ugosan
Copy link
Contributor

@ugosan ugosan commented Jul 6, 2017

Adding information about user and password for ES with X-Pack

Description

updated the README

@codecov-io
Copy link

codecov-io commented Jul 6, 2017

Codecov Report

Merging #185 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #185   +/-   ##
=======================================
  Coverage   61.85%   61.85%           
=======================================
  Files          38       38           
  Lines        1345     1345           
=======================================
  Hits          832      832           
  Misses        513      513

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35c184f...902122d. Read the comment docs.

@sckott
Copy link
Contributor

sckott commented Jul 11, 2017

thanks @ugosan

hadn't mentioned that as it's a paid service and I only use the OS version

@sckott sckott merged commit cca6c4e into ropensci:master Jul 11, 2017
@sckott sckott added this to the v0.8 milestone Jul 11, 2017
@ugosan
Copy link
Contributor Author

ugosan commented Jul 12, 2017

Sure, that also works if you have NGINX as a reverse proxy with basic http authentication

@sckott
Copy link
Contributor

sckott commented Jul 12, 2017

thanks, will do soon for testing

@sckott sckott mentioned this pull request Jul 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants