Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

track_total_hits in request for elastic >= 7.0 #262

Merged
merged 1 commit into from
Jul 25, 2019

Conversation

orenov
Copy link
Contributor

@orenov orenov commented Jul 20, 2019

Adding track_total_hits param in a request. As it's the only way how to get exact counts using the Search function. https://www.elastic.co/guide/en/elasticsearch/reference/current/search-request-track-total-hits.html

Unfortunately, I didn't test it much, but I hope it's ok as it's simple.

I had an assumption that this parameter was introduced with elasticsearch 7.0.

@orenov orenov changed the title track_total_hits in request for elastic 7.0 track_total_hits in request for elastic >= 7.0 Jul 20, 2019
Copy link
Contributor

@sckott sckott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR

R/search.r Outdated Show resolved Hide resolved
@sckott sckott added this to the v1.1 milestone Jul 22, 2019
@sckott sckott merged commit 30faff5 into ropensci:master Jul 25, 2019
@orenov orenov deleted the exact-count branch April 14, 2020 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants