Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brief output for geojson_json #86

Closed
sckott opened this issue Jun 6, 2016 · 12 comments · Fixed by #124
Closed

brief output for geojson_json #86

sckott opened this issue Jun 6, 2016 · 12 comments · Fixed by #124
Milestone

Comments

@sckott
Copy link
Collaborator

sckott commented Jun 6, 2016

These functions can return very verbose output.

Thinking about print methods for each that only give very brief output and calculate some summary information to print as well if possible

@ateucher
Copy link
Member

ateucher commented Jun 6, 2016

Great idea! Include: geometry type, crs, bounding box, number of features, field names (and types)... head of data?

@sckott
Copy link
Collaborator Author

sckott commented Jun 6, 2016

cool . - I think it makes sense to follow what we'll do for the geojson package https://github.com/ropenscilabs/geojson

@ateucher
Copy link
Member

ateucher commented Jun 6, 2016

Oh nice. So what's the relationship there... is the intent to have this (and all other geojson-focussed packages such as lawn) depend on geojson package for the classes?

@sckott
Copy link
Collaborator Author

sckott commented Jun 6, 2016

geojson is like sp, with classes for all geojson data types, and some very minimal manipulation tools sans depending on sp/rgdal/etc.

and https://github.com/ropenscilabs/geoops for trying to have equiv. to rgdal/rgeos (a subset of their operations at least), but only using jqr if possible

For geojsonio though, i just meant follow what we'll use for geojson for a print method for defining classes - though this isn't super important, anyway, will get something drafter and ask for your feedback

@ateucher
Copy link
Member

ateucher commented Jun 6, 2016

Ok, that's what I figured...

@sckott sckott added this to the v0.3 milestone Jun 8, 2016
@sckott sckott modified the milestones: v0.4, v0.3 Jan 11, 2017
@sckott
Copy link
Collaborator Author

sckott commented Jan 11, 2017

moving this to next milestone, I think we should send what we have so far for v0.3 https://github.com/ropensci/geojsonio/milestone/3?closed=1

sckott added a commit that referenced this issue Aug 15, 2017
@sckott
Copy link
Collaborator Author

sckott commented Aug 15, 2017

@ateucher can you take a look and tell me what you think? install devtools::install_github("ropensci/geojsonio@json-brief")

@sckott
Copy link
Collaborator Author

sckott commented Aug 15, 2017

changes only in geojson_json function - just run examples to see after installation

@sckott sckott modified the milestones: v0.5, v0.4 Aug 19, 2017
@fmichonneau
Copy link
Member

+1 for this. I too often crash my R session by trying to print a 10Mb geo_json object 😐

@sckott
Copy link
Collaborator Author

sckott commented Oct 23, 2017

thanks @fmichonneau motivation to get this done sooner

@sckott
Copy link
Collaborator Author

sckott commented Oct 24, 2017

Since it'd be best to handoff the heavy lifting to geojson, i think we move forward with brief output for json as a string for now and then do brief output for lists once lists are supported in geojson - see ropensci/geojson#18

@sckott sckott changed the title brief output for geojson_json and geojson_list brief output for geojson_json Oct 24, 2017
@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants