Skip to content

Commit

Permalink
fix #41 updated description file with cph and ctb
Browse files Browse the repository at this point in the history
updated cran-comments with detailed explanation of changes
  • Loading branch information
sckott committed Mar 23, 2016
1 parent f060292 commit 7e4b790
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 1 deletion.
6 changes: 5 additions & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@ Authors@R: c(person("Rich", "FitzJohn", role = "aut",
email = "myrmecocystus@gmail.com"),
person("Stefan Milton Bache", role = "aut",
email = "stefan@stefanbache.dk"),
person("Stephen", "Dolan", role = "cph"))
person("Stephen", "Dolan", role = c("aut","cph"), comment = "jq library"),
person(family = "jq contributors", role = "ctb",
comment = "jq library; authors listed in inst/AUTHORS.jq"),
person("Free Software Foundation", role = c("ctb","cph"), comment = "parser code in src/parser.c"),
person("David M", "Gay", role = c("ctb","cph"), comment = "code in src/jv_dtoa.c"))
VignetteBuilder: knitr
SystemRequirements: GNU make
URL: https://github.com/ropensci/jqr
Expand Down
27 changes: 27 additions & 0 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,33 @@ R development version, Ubuntu running on Travis-CI, and WinBuilder.

This is a new package.

This is a re-submission of the first submission. I was asked to
look over again the authors, license, and copyright information.

In terms of authors and copyright, I have updated the DESCRIPTION
file with ctb and cph notes for jq, some C code by David Gay, and
the bison parser.

In terms of license, jq is MIT and other C code included by David Gay
is also MIT licensed. A dependency in jq, bison, is GPL licensed.
However, bison has a special exception:

As a special exception, you may create a larger work that contains
part or all of the Bison parser skeleton and distribute that work
under terms of your choice, so long as that work isn't itself a
parser generator using the skeleton or a modified version thereof
as a parser skeleton. Alternatively, if you modify or redistribute
the parser skeleton itself, you may (at your option) remove this
special exception, which will cause the skeleton and the resulting
Bison output files to be licensed under the GNU General Public
License without this special exception. This special exception was
added by the Free Software Foundation in version 2.2 of Bison.

If I understand this correctly, this means we can license this package
under MIT since this package is not a parser generator itself. The fact
that jq is licensed under MIT suggests that we can as well. I hope
I have interpreted this correctly. Please let me know if you disagree.

Note that CHECK says that 'jq' should be sentence cased, but that is
an improper spelling of the software.

Expand Down

0 comments on commit 7e4b790

Please sign in to comment.