Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address tzdata breaking changes #64

Merged
merged 4 commits into from
Dec 1, 2024
Merged

Address tzdata breaking changes #64

merged 4 commits into from
Dec 1, 2024

Conversation

Bisaloo
Copy link
Member

@Bisaloo Bisaloo commented Nov 18, 2024

As reported by CRAN:

Dear maintainer,

Please see the problems shown on https://cran.r-project.org/web/checks/check_results_lightr.html.

The errors on the Debian check systems are from a recent system upgrade
to tzdata 2024b which did

   Names present only for compatibility with UNIX System V
   (last released in the 1990s) have been moved to 'backward'.

which includes CET, CST6CDT, EET, EST*, HST, MET, MST*, PST8PDT, and
WET.

Debian ships the names in 'backward' in a separate package tzdata-legacy
which is not installed "by default".

The comments in the tzdata 'backward' file say

# Although this file is optional and tzdb will work if you omit it by
# building with 'make BACKWARD=', in practice downstream users
# typically use this file for backward compatibility.

so clearly one cannot unconditionally assume that the backward
compatibility names will work.

To be fixed before 2024-12-09

@Bisaloo
Copy link
Member Author

Bisaloo commented Nov 22, 2024 •
edited
Loading

Confirmed today with the rocker/r-devel image, based on debian testing.

New OlsonNames() output 
  [1] "Africa/Abidjan"                 "Africa/Accra"                  
  [3] "Africa/Addis_Ababa"             "Africa/Algiers"                
  [5] "Africa/Asmara"                  "Africa/Bamako"                 
  [7] "Africa/Bangui"                  "Africa/Banjul"                 
  [9] "Africa/Bissau"                  "Africa/Blantyre"               
 [11] "Africa/Brazzaville"             "Africa/Bujumbura"              
 [13] "Africa/Cairo"                   "Africa/Casablanca"             
 [15] "Africa/Ceuta"                   "Africa/Conakry"                
 [17] "Africa/Dakar"                   "Africa/Dar_es_Salaam"          
 [19] "Africa/Djibouti"                "Africa/Douala"                 
 [21] "Africa/El_Aaiun"                "Africa/Freetown"               
 [23] "Africa/Gaborone"                "Africa/Harare"                 
 [25] "Africa/Johannesburg"            "Africa/Juba"                   
 [27] "Africa/Kampala"                 "Africa/Khartoum"               
 [29] "Africa/Kigali"                  "Africa/Kinshasa"               
 [31] "Africa/Lagos"                   "Africa/Libreville"             
 [33] "Africa/Lome"                    "Africa/Luanda"                 
 [35] "Africa/Lubumbashi"              "Africa/Lusaka"                 
 [37] "Africa/Malabo"                  "Africa/Maputo"                 
 [39] "Africa/Maseru"                  "Africa/Mbabane"                
 [41] "Africa/Mogadishu"               "Africa/Monrovia"               
 [43] "Africa/Nairobi"                 "Africa/Ndjamena"               
 [45] "Africa/Niamey"                  "Africa/Nouakchott"             
 [47] "Africa/Ouagadougou"             "Africa/Porto-Novo"             
 [49] "Africa/Sao_Tome"                "Africa/Timbuktu"               
 [51] "Africa/Tripoli"                 "Africa/Tunis"                  
 [53] "Africa/Windhoek"                "America/Adak"                  
 [55] "America/Anchorage"              "America/Anguilla"              
 [57] "America/Antigua"                "America/Araguaina"             
 [59] "America/Argentina/Buenos_Aires" "America/Argentina/Catamarca"   
 [61] "America/Argentina/Cordoba"      "America/Argentina/Jujuy"       
 [63] "America/Argentina/La_Rioja"     "America/Argentina/Mendoza"     
 [65] "America/Argentina/Rio_Gallegos" "America/Argentina/Salta"       
 [67] "America/Argentina/San_Juan"     "America/Argentina/San_Luis"    
 [69] "America/Argentina/Tucuman"      "America/Argentina/Ushuaia"     
 [71] "America/Aruba"                  "America/Asuncion"              
 [73] "America/Atikokan"               "America/Atka"                  
 [75] "America/Bahia"                  "America/Bahia_Banderas"        
 [77] "America/Barbados"               "America/Belem"                 
 [79] "America/Belize"                 "America/Blanc-Sablon"          
 [81] "America/Boa_Vista"              "America/Bogota"                
 [83] "America/Boise"                  "America/Cambridge_Bay"         
 [85] "America/Campo_Grande"           "America/Cancun"                
 [87] "America/Caracas"                "America/Cayenne"               
 [89] "America/Cayman"                 "America/Chicago"               
 [91] "America/Chihuahua"              "America/Ciudad_Juarez"         
 [93] "America/Coral_Harbour"          "America/Costa_Rica"            
 [95] "America/Creston"                "America/Cuiaba"                
 [97] "America/Curacao"                "America/Danmarkshavn"          
 [99] "America/Dawson"                 "America/Dawson_Creek"          
[101] "America/Denver"                 "America/Detroit"               
[103] "America/Dominica"               "America/Edmonton"              
[105] "America/Eirunepe"               "America/El_Salvador"           
[107] "America/Ensenada"               "America/Fort_Nelson"           
[109] "America/Fortaleza"              "America/Glace_Bay"             
[111] "America/Goose_Bay"              "America/Grand_Turk"            
[113] "America/Grenada"                "America/Guadeloupe"            
[115] "America/Guatemala"              "America/Guayaquil"             
[117] "America/Guyana"                 "America/Halifax"               
[119] "America/Havana"                 "America/Hermosillo"            
[121] "America/Indiana/Indianapolis"   "America/Indiana/Knox"          
[123] "America/Indiana/Marengo"        "America/Indiana/Petersburg"    
[125] "America/Indiana/Tell_City"      "America/Indiana/Vevay"         
[127] "America/Indiana/Vincennes"      "America/Indiana/Winamac"       
[129] "America/Inuvik"                 "America/Iqaluit"               
[131] "America/Jamaica"                "America/Juneau"                
[133] "America/Kentucky/Louisville"    "America/Kentucky/Monticello"   
[135] "America/Kralendijk"             "America/La_Paz"                
[137] "America/Lima"                   "America/Los_Angeles"           
[139] "America/Lower_Princes"          "America/Maceio"                
[141] "America/Managua"                "America/Manaus"                
[143] "America/Marigot"                "America/Martinique"            
[145] "America/Matamoros"              "America/Mazatlan"              
[147] "America/Menominee"              "America/Merida"                
[149] "America/Metlakatla"             "America/Mexico_City"           
[151] "America/Miquelon"               "America/Moncton"               
[153] "America/Monterrey"              "America/Montevideo"            
[155] "America/Montreal"               "America/Montserrat"            
[157] "America/Nassau"                 "America/New_York"              
[159] "America/Nipigon"                "America/Nome"                  
[161] "America/Noronha"                "America/North_Dakota/Beulah"   
[163] "America/North_Dakota/Center"    "America/North_Dakota/New_Salem"
[165] "America/Nuuk"                   "America/Ojinaga"               
[167] "America/Panama"                 "America/Pangnirtung"           
[169] "America/Paramaribo"             "America/Phoenix"               
[171] "America/Port_of_Spain"          "America/Port-au-Prince"        
[173] "America/Porto_Acre"             "America/Porto_Velho"           
[175] "America/Puerto_Rico"            "America/Punta_Arenas"          
[177] "America/Rainy_River"            "America/Rankin_Inlet"          
[179] "America/Recife"                 "America/Regina"                
[181] "America/Resolute"               "America/Rio_Branco"            
[183] "America/Santa_Isabel"           "America/Santarem"              
[185] "America/Santiago"               "America/Santo_Domingo"         
[187] "America/Sao_Paulo"              "America/Scoresbysund"          
[189] "America/Shiprock"               "America/Sitka"                 
[191] "America/St_Barthelemy"          "America/St_Johns"              
[193] "America/St_Kitts"               "America/St_Lucia"              
[195] "America/St_Thomas"              "America/St_Vincent"            
[197] "America/Swift_Current"          "America/Tegucigalpa"           
[199] "America/Thule"                  "America/Thunder_Bay"           
[201] "America/Tijuana"                "America/Toronto"               
[203] "America/Tortola"                "America/Vancouver"             
[205] "America/Virgin"                 "America/Whitehorse"            
[207] "America/Winnipeg"               "America/Yakutat"               
[209] "America/Yellowknife"            "Antarctica/Casey"              
[211] "Antarctica/Davis"               "Antarctica/DumontDUrville"     
[213] "Antarctica/Macquarie"           "Antarctica/Mawson"             
[215] "Antarctica/McMurdo"             "Antarctica/Palmer"             
[217] "Antarctica/Rothera"             "Antarctica/Syowa"              
[219] "Antarctica/Troll"               "Antarctica/Vostok"             
[221] "Arctic/Longyearbyen"            "Asia/Aden"                     
[223] "Asia/Almaty"                    "Asia/Amman"                    
[225] "Asia/Anadyr"                    "Asia/Aqtau"                    
[227] "Asia/Aqtobe"                    "Asia/Ashgabat"                 
[229] "Asia/Atyrau"                    "Asia/Baghdad"                  
[231] "Asia/Bahrain"                   "Asia/Baku"                     
[233] "Asia/Bangkok"                   "Asia/Barnaul"                  
[235] "Asia/Beirut"                    "Asia/Bishkek"                  
[237] "Asia/Brunei"                    "Asia/Chita"                    
[239] "Asia/Chongqing"                 "Asia/Colombo"                  
[241] "Asia/Damascus"                  "Asia/Dhaka"                    
[243] "Asia/Dili"                      "Asia/Dubai"                    
[245] "Asia/Dushanbe"                  "Asia/Famagusta"                
[247] "Asia/Gaza"                      "Asia/Harbin"                   
[249] "Asia/Hebron"                    "Asia/Ho_Chi_Minh"              
[251] "Asia/Hong_Kong"                 "Asia/Hovd"                     
[253] "Asia/Irkutsk"                   "Asia/Istanbul"                 
[255] "Asia/Jakarta"                   "Asia/Jayapura"                 
[257] "Asia/Jerusalem"                 "Asia/Kabul"                    
[259] "Asia/Kamchatka"                 "Asia/Karachi"                  
[261] "Asia/Kashgar"                   "Asia/Kathmandu"                
[263] "Asia/Khandyga"                  "Asia/Kolkata"                  
[265] "Asia/Krasnoyarsk"               "Asia/Kuala_Lumpur"             
[267] "Asia/Kuching"                   "Asia/Kuwait"                   
[269] "Asia/Macau"                     "Asia/Magadan"                  
[271] "Asia/Makassar"                  "Asia/Manila"                   
[273] "Asia/Muscat"                    "Asia/Nicosia"                  
[275] "Asia/Novokuznetsk"              "Asia/Novosibirsk"              
[277] "Asia/Omsk"                      "Asia/Oral"                     
[279] "Asia/Phnom_Penh"                "Asia/Pontianak"                
[281] "Asia/Pyongyang"                 "Asia/Qatar"                    
[283] "Asia/Qostanay"                  "Asia/Qyzylorda"                
[285] "Asia/Riyadh"                    "Asia/Sakhalin"                 
[287] "Asia/Samarkand"                 "Asia/Seoul"                    
[289] "Asia/Shanghai"                  "Asia/Singapore"                
[291] "Asia/Srednekolymsk"             "Asia/Taipei"                   
[293] "Asia/Tashkent"                  "Asia/Tbilisi"                  
[295] "Asia/Tehran"                    "Asia/Tel_Aviv"                 
[297] "Asia/Thimphu"                   "Asia/Tokyo"                    
[299] "Asia/Tomsk"                     "Asia/Ulaanbaatar"              
[301] "Asia/Urumqi"                    "Asia/Ust-Nera"                 
[303] "Asia/Vientiane"                 "Asia/Vladivostok"              
[305] "Asia/Yakutsk"                   "Asia/Yangon"                   
[307] "Asia/Yekaterinburg"             "Asia/Yerevan"                  
[309] "Atlantic/Azores"                "Atlantic/Bermuda"              
[311] "Atlantic/Canary"                "Atlantic/Cape_Verde"           
[313] "Atlantic/Faroe"                 "Atlantic/Jan_Mayen"            
[315] "Atlantic/Madeira"               "Atlantic/Reykjavik"            
[317] "Atlantic/South_Georgia"         "Atlantic/St_Helena"            
[319] "Atlantic/Stanley"               "Australia/Adelaide"            
[321] "Australia/Brisbane"             "Australia/Broken_Hill"         
[323] "Australia/Canberra"             "Australia/Currie"              
[325] "Australia/Darwin"               "Australia/Eucla"               
[327] "Australia/Hobart"               "Australia/Lindeman"            
[329] "Australia/Lord_Howe"            "Australia/Melbourne"           
[331] "Australia/Perth"                "Australia/Sydney"              
[333] "Australia/Yancowinna"           "Etc/GMT"                       
[335] "Etc/GMT-0"                      "Etc/GMT-1"                     
[337] "Etc/GMT-10"                     "Etc/GMT-11"                    
[339] "Etc/GMT-12"                     "Etc/GMT-13"                    
[341] "Etc/GMT-14"                     "Etc/GMT-2"                     
[343] "Etc/GMT-3"                      "Etc/GMT-4"                     
[345] "Etc/GMT-5"                      "Etc/GMT-6"                     
[347] "Etc/GMT-7"                      "Etc/GMT-8"                     
[349] "Etc/GMT-9"                      "Etc/GMT+0"                     
[351] "Etc/GMT+1"                      "Etc/GMT+10"                    
[353] "Etc/GMT+11"                     "Etc/GMT+12"                    
[355] "Etc/GMT+2"                      "Etc/GMT+3"                     
[357] "Etc/GMT+4"                      "Etc/GMT+5"                     
[359] "Etc/GMT+6"                      "Etc/GMT+7"                     
[361] "Etc/GMT+8"                      "Etc/GMT+9"                     
[363] "Etc/GMT0"                       "Etc/Greenwich"                 
[365] "Etc/UCT"                        "Etc/Universal"                 
[367] "Etc/UTC"                        "Etc/Zulu"                      
[369] "Europe/Amsterdam"               "Europe/Andorra"                
[371] "Europe/Astrakhan"               "Europe/Athens"                 
[373] "Europe/Belfast"                 "Europe/Belgrade"               
[375] "Europe/Berlin"                  "Europe/Bratislava"             
[377] "Europe/Brussels"                "Europe/Bucharest"              
[379] "Europe/Budapest"                "Europe/Busingen"               
[381] "Europe/Chisinau"                "Europe/Copenhagen"             
[383] "Europe/Dublin"                  "Europe/Gibraltar"              
[385] "Europe/Guernsey"                "Europe/Helsinki"               
[387] "Europe/Isle_of_Man"             "Europe/Istanbul"               
[389] "Europe/Jersey"                  "Europe/Kaliningrad"            
[391] "Europe/Kirov"                   "Europe/Kyiv"                   
[393] "Europe/Lisbon"                  "Europe/Ljubljana"              
[395] "Europe/London"                  "Europe/Luxembourg"             
[397] "Europe/Madrid"                  "Europe/Malta"                  
[399] "Europe/Mariehamn"               "Europe/Minsk"                  
[401] "Europe/Monaco"                  "Europe/Moscow"                 
[403] "Europe/Nicosia"                 "Europe/Oslo"                   
[405] "Europe/Paris"                   "Europe/Podgorica"              
[407] "Europe/Prague"                  "Europe/Riga"                   
[409] "Europe/Rome"                    "Europe/Samara"                 
[411] "Europe/San_Marino"              "Europe/Sarajevo"               
[413] "Europe/Saratov"                 "Europe/Simferopol"             
[415] "Europe/Skopje"                  "Europe/Sofia"                  
[417] "Europe/Stockholm"               "Europe/Tallinn"                
[419] "Europe/Tirane"                  "Europe/Tiraspol"               
[421] "Europe/Ulyanovsk"               "Europe/Vaduz"                  
[423] "Europe/Vatican"                 "Europe/Vienna"                 
[425] "Europe/Vilnius"                 "Europe/Volgograd"              
[427] "Europe/Warsaw"                  "Europe/Zagreb"                 
[429] "Europe/Zurich"                  "Factory"                       
[431] "GMT"                            "Indian/Antananarivo"           
[433] "Indian/Chagos"                  "Indian/Christmas"              
[435] "Indian/Cocos"                   "Indian/Comoro"                 
[437] "Indian/Kerguelen"               "Indian/Mahe"                   
[439] "Indian/Maldives"                "Indian/Mauritius"              
[441] "Indian/Mayotte"                 "Indian/Reunion"                
[443] "Pacific/Apia"                   "Pacific/Auckland"              
[445] "Pacific/Bougainville"           "Pacific/Chatham"               
[447] "Pacific/Chuuk"                  "Pacific/Easter"                
[449] "Pacific/Efate"                  "Pacific/Fakaofo"               
[451] "Pacific/Fiji"                   "Pacific/Funafuti"              
[453] "Pacific/Galapagos"              "Pacific/Gambier"               
[455] "Pacific/Guadalcanal"            "Pacific/Guam"                  
[457] "Pacific/Honolulu"               "Pacific/Johnston"              
[459] "Pacific/Kanton"                 "Pacific/Kiritimati"            
[461] "Pacific/Kosrae"                 "Pacific/Kwajalein"             
[463] "Pacific/Majuro"                 "Pacific/Marquesas"             
[465] "Pacific/Midway"                 "Pacific/Nauru"                 
[467] "Pacific/Niue"                   "Pacific/Norfolk"               
[469] "Pacific/Noumea"                 "Pacific/Pago_Pago"             
[471] "Pacific/Palau"                  "Pacific/Pitcairn"              
[473] "Pacific/Pohnpei"                "Pacific/Port_Moresby"          
[475] "Pacific/Rarotonga"              "Pacific/Saipan"                
[477] "Pacific/Samoa"                  "Pacific/Tahiti"                
[479] "Pacific/Tarawa"                 "Pacific/Tongatapu"             
[481] "Pacific/Wake"                   "Pacific/Wallis"                
[483] "Pacific/Yap"                    "UTC"                           
attr(,"Version")
[1] "2024b"
Old OlsonNames() output 
  [1] "Africa/Abidjan"                 "Africa/Accra"                  
  [3] "Africa/Addis_Ababa"             "Africa/Algiers"                
  [5] "Africa/Asmara"                  "Africa/Bamako"                 
  [7] "Africa/Bangui"                  "Africa/Banjul"                 
  [9] "Africa/Bissau"                  "Africa/Blantyre"               
 [11] "Africa/Brazzaville"             "Africa/Bujumbura"              
 [13] "Africa/Cairo"                   "Africa/Casablanca"             
 [15] "Africa/Ceuta"                   "Africa/Conakry"                
 [17] "Africa/Dakar"                   "Africa/Dar_es_Salaam"          
 [19] "Africa/Djibouti"                "Africa/Douala"                 
 [21] "Africa/El_Aaiun"                "Africa/Freetown"               
 [23] "Africa/Gaborone"                "Africa/Harare"                 
 [25] "Africa/Johannesburg"            "Africa/Juba"                   
 [27] "Africa/Kampala"                 "Africa/Khartoum"               
 [29] "Africa/Kigali"                  "Africa/Kinshasa"               
 [31] "Africa/Lagos"                   "Africa/Libreville"             
 [33] "Africa/Lome"                    "Africa/Luanda"                 
 [35] "Africa/Lubumbashi"              "Africa/Lusaka"                 
 [37] "Africa/Malabo"                  "Africa/Maputo"                 
 [39] "Africa/Maseru"                  "Africa/Mbabane"                
 [41] "Africa/Mogadishu"               "Africa/Monrovia"               
 [43] "Africa/Nairobi"                 "Africa/Ndjamena"               
 [45] "Africa/Niamey"                  "Africa/Nouakchott"             
 [47] "Africa/Ouagadougou"             "Africa/Porto-Novo"             
 [49] "Africa/Sao_Tome"                "Africa/Timbuktu"               
 [51] "Africa/Tripoli"                 "Africa/Tunis"                  
 [53] "Africa/Windhoek"                "America/Adak"                  
 [55] "America/Anchorage"              "America/Anguilla"              
 [57] "America/Antigua"                "America/Araguaina"             
 [59] "America/Argentina/Buenos_Aires" "America/Argentina/Catamarca"   
 [61] "America/Argentina/Cordoba"      "America/Argentina/Jujuy"       
 [63] "America/Argentina/La_Rioja"     "America/Argentina/Mendoza"     
 [65] "America/Argentina/Rio_Gallegos" "America/Argentina/Salta"       
 [67] "America/Argentina/San_Juan"     "America/Argentina/San_Luis"    
 [69] "America/Argentina/Tucuman"      "America/Argentina/Ushuaia"     
 [71] "America/Aruba"                  "America/Asuncion"              
 [73] "America/Atikokan"               "America/Atka"                  
 [75] "America/Bahia"                  "America/Bahia_Banderas"        
 [77] "America/Barbados"               "America/Belem"                 
 [79] "America/Belize"                 "America/Blanc-Sablon"          
 [81] "America/Boa_Vista"              "America/Bogota"                
 [83] "America/Boise"                  "America/Cambridge_Bay"         
 [85] "America/Campo_Grande"           "America/Cancun"                
 [87] "America/Caracas"                "America/Cayenne"               
 [89] "America/Cayman"                 "America/Chicago"               
 [91] "America/Chihuahua"              "America/Ciudad_Juarez"         
 [93] "America/Coral_Harbour"          "America/Costa_Rica"            
 [95] "America/Creston"                "America/Cuiaba"                
 [97] "America/Curacao"                "America/Danmarkshavn"          
 [99] "America/Dawson"                 "America/Dawson_Creek"          
[101] "America/Denver"                 "America/Detroit"               
[103] "America/Dominica"               "America/Edmonton"              
[105] "America/Eirunepe"               "America/El_Salvador"           
[107] "America/Ensenada"               "America/Fort_Nelson"           
[109] "America/Fortaleza"              "America/Glace_Bay"             
[111] "America/Goose_Bay"              "America/Grand_Turk"            
[113] "America/Grenada"                "America/Guadeloupe"            
[115] "America/Guatemala"              "America/Guayaquil"             
[117] "America/Guyana"                 "America/Halifax"               
[119] "America/Havana"                 "America/Hermosillo"            
[121] "America/Indiana/Indianapolis"   "America/Indiana/Knox"          
[123] "America/Indiana/Marengo"        "America/Indiana/Petersburg"    
[125] "America/Indiana/Tell_City"      "America/Indiana/Vevay"         
[127] "America/Indiana/Vincennes"      "America/Indiana/Winamac"       
[129] "America/Inuvik"                 "America/Iqaluit"               
[131] "America/Jamaica"                "America/Juneau"                
[133] "America/Kentucky/Louisville"    "America/Kentucky/Monticello"   
[135] "America/Kralendijk"             "America/La_Paz"                
[137] "America/Lima"                   "America/Los_Angeles"           
[139] "America/Lower_Princes"          "America/Maceio"                
[141] "America/Managua"                "America/Manaus"                
[143] "America/Marigot"                "America/Martinique"            
[145] "America/Matamoros"              "America/Mazatlan"              
[147] "America/Menominee"              "America/Merida"                
[149] "America/Metlakatla"             "America/Mexico_City"           
[151] "America/Miquelon"               "America/Moncton"               
[153] "America/Monterrey"              "America/Montevideo"            
[155] "America/Montreal"               "America/Montserrat"            
[157] "America/Nassau"                 "America/New_York"              
[159] "America/Nipigon"                "America/Nome"                  
[161] "America/Noronha"                "America/North_Dakota/Beulah"   
[163] "America/North_Dakota/Center"    "America/North_Dakota/New_Salem"
[165] "America/Nuuk"                   "America/Ojinaga"               
[167] "America/Panama"                 "America/Pangnirtung"           
[169] "America/Paramaribo"             "America/Phoenix"               
[171] "America/Port_of_Spain"          "America/Port-au-Prince"        
[173] "America/Porto_Acre"             "America/Porto_Velho"           
[175] "America/Puerto_Rico"            "America/Punta_Arenas"          
[177] "America/Rainy_River"            "America/Rankin_Inlet"          
[179] "America/Recife"                 "America/Regina"                
[181] "America/Resolute"               "America/Rio_Branco"            
[183] "America/Santa_Isabel"           "America/Santarem"              
[185] "America/Santiago"               "America/Santo_Domingo"         
[187] "America/Sao_Paulo"              "America/Scoresbysund"          
[189] "America/Shiprock"               "America/Sitka"                 
[191] "America/St_Barthelemy"          "America/St_Johns"              
[193] "America/St_Kitts"               "America/St_Lucia"              
[195] "America/St_Thomas"              "America/St_Vincent"            
[197] "America/Swift_Current"          "America/Tegucigalpa"           
[199] "America/Thule"                  "America/Thunder_Bay"           
[201] "America/Tijuana"                "America/Toronto"               
[203] "America/Tortola"                "America/Vancouver"             
[205] "America/Virgin"                 "America/Whitehorse"            
[207] "America/Winnipeg"               "America/Yakutat"               
[209] "America/Yellowknife"            "Antarctica/Casey"              
[211] "Antarctica/Davis"               "Antarctica/DumontDUrville"     
[213] "Antarctica/Macquarie"           "Antarctica/Mawson"             
[215] "Antarctica/McMurdo"             "Antarctica/Palmer"             
[217] "Antarctica/Rothera"             "Antarctica/Syowa"              
[219] "Antarctica/Troll"               "Antarctica/Vostok"             
[221] "Arctic/Longyearbyen"            "Asia/Aden"                     
[223] "Asia/Almaty"                    "Asia/Amman"                    
[225] "Asia/Anadyr"                    "Asia/Aqtau"                    
[227] "Asia/Aqtobe"                    "Asia/Ashgabat"                 
[229] "Asia/Atyrau"                    "Asia/Baghdad"                  
[231] "Asia/Bahrain"                   "Asia/Baku"                     
[233] "Asia/Bangkok"                   "Asia/Barnaul"                  
[235] "Asia/Beirut"                    "Asia/Bishkek"                  
[237] "Asia/Brunei"                    "Asia/Chita"                    
[239] "Asia/Choibalsan"                "Asia/Chongqing"                
[241] "Asia/Colombo"                   "Asia/Damascus"                 
[243] "Asia/Dhaka"                     "Asia/Dili"                     
[245] "Asia/Dubai"                     "Asia/Dushanbe"                 
[247] "Asia/Famagusta"                 "Asia/Gaza"                     
[249] "Asia/Harbin"                    "Asia/Hebron"                   
[251] "Asia/Ho_Chi_Minh"               "Asia/Hong_Kong"                
[253] "Asia/Hovd"                      "Asia/Irkutsk"                  
[255] "Asia/Istanbul"                  "Asia/Jakarta"                  
[257] "Asia/Jayapura"                  "Asia/Jerusalem"                
[259] "Asia/Kabul"                     "Asia/Kamchatka"                
[261] "Asia/Karachi"                   "Asia/Kashgar"                  
[263] "Asia/Kathmandu"                 "Asia/Khandyga"                 
[265] "Asia/Kolkata"                   "Asia/Krasnoyarsk"              
[267] "Asia/Kuala_Lumpur"              "Asia/Kuching"                  
[269] "Asia/Kuwait"                    "Asia/Macau"                    
[271] "Asia/Magadan"                   "Asia/Makassar"                 
[273] "Asia/Manila"                    "Asia/Muscat"                   
[275] "Asia/Nicosia"                   "Asia/Novokuznetsk"             
[277] "Asia/Novosibirsk"               "Asia/Omsk"                     
[279] "Asia/Oral"                      "Asia/Phnom_Penh"               
[281] "Asia/Pontianak"                 "Asia/Pyongyang"                
[283] "Asia/Qatar"                     "Asia/Qostanay"                 
[285] "Asia/Qyzylorda"                 "Asia/Riyadh"                   
[287] "Asia/Sakhalin"                  "Asia/Samarkand"                
[289] "Asia/Seoul"                     "Asia/Shanghai"                 
[291] "Asia/Singapore"                 "Asia/Srednekolymsk"            
[293] "Asia/Taipei"                    "Asia/Tashkent"                 
[295] "Asia/Tbilisi"                   "Asia/Tehran"                   
[297] "Asia/Tel_Aviv"                  "Asia/Thimphu"                  
[299] "Asia/Tokyo"                     "Asia/Tomsk"                    
[301] "Asia/Ulaanbaatar"               "Asia/Urumqi"                   
[303] "Asia/Ust-Nera"                  "Asia/Vientiane"                
[305] "Asia/Vladivostok"               "Asia/Yakutsk"                  
[307] "Asia/Yangon"                    "Asia/Yekaterinburg"            
[309] "Asia/Yerevan"                   "Atlantic/Azores"               
[311] "Atlantic/Bermuda"               "Atlantic/Canary"               
[313] "Atlantic/Cape_Verde"            "Atlantic/Faroe"                
[315] "Atlantic/Jan_Mayen"             "Atlantic/Madeira"              
[317] "Atlantic/Reykjavik"             "Atlantic/South_Georgia"        
[319] "Atlantic/St_Helena"             "Atlantic/Stanley"              
[321] "Australia/Adelaide"             "Australia/Brisbane"            
[323] "Australia/Broken_Hill"          "Australia/Canberra"            
[325] "Australia/Currie"               "Australia/Darwin"              
[327] "Australia/Eucla"                "Australia/Hobart"              
[329] "Australia/Lindeman"             "Australia/Lord_Howe"           
[331] "Australia/Melbourne"            "Australia/Perth"               
[333] "Australia/Sydney"               "Australia/Yancowinna"          
[335] "CET"                            "CST6CDT"                       
[337] "EET"                            "EST"                           
[339] "EST5EDT"                        "Etc/GMT"                       
[341] "Etc/GMT-0"                      "Etc/GMT-1"                     
[343] "Etc/GMT-10"                     "Etc/GMT-11"                    
[345] "Etc/GMT-12"                     "Etc/GMT-13"                    
[347] "Etc/GMT-14"                     "Etc/GMT-2"                     
[349] "Etc/GMT-3"                      "Etc/GMT-4"                     
[351] "Etc/GMT-5"                      "Etc/GMT-6"                     
[353] "Etc/GMT-7"                      "Etc/GMT-8"                     
[355] "Etc/GMT-9"                      "Etc/GMT+0"                     
[357] "Etc/GMT+1"                      "Etc/GMT+10"                    
[359] "Etc/GMT+11"                     "Etc/GMT+12"                    
[361] "Etc/GMT+2"                      "Etc/GMT+3"                     
[363] "Etc/GMT+4"                      "Etc/GMT+5"                     
[365] "Etc/GMT+6"                      "Etc/GMT+7"                     
[367] "Etc/GMT+8"                      "Etc/GMT+9"                     
[369] "Etc/GMT0"                       "Etc/Greenwich"                 
[371] "Etc/UCT"                        "Etc/Universal"                 
[373] "Etc/UTC"                        "Etc/Zulu"                      
[375] "Europe/Amsterdam"               "Europe/Andorra"                
[377] "Europe/Astrakhan"               "Europe/Athens"                 
[379] "Europe/Belfast"                 "Europe/Belgrade"               
[381] "Europe/Berlin"                  "Europe/Bratislava"             
[383] "Europe/Brussels"                "Europe/Bucharest"              
[385] "Europe/Budapest"                "Europe/Busingen"               
[387] "Europe/Chisinau"                "Europe/Copenhagen"             
[389] "Europe/Dublin"                  "Europe/Gibraltar"              
[391] "Europe/Guernsey"                "Europe/Helsinki"               
[393] "Europe/Isle_of_Man"             "Europe/Istanbul"               
[395] "Europe/Jersey"                  "Europe/Kaliningrad"            
[397] "Europe/Kirov"                   "Europe/Kyiv"                   
[399] "Europe/Lisbon"                  "Europe/Ljubljana"              
[401] "Europe/London"                  "Europe/Luxembourg"             
[403] "Europe/Madrid"                  "Europe/Malta"                  
[405] "Europe/Mariehamn"               "Europe/Minsk"                  
[407] "Europe/Monaco"                  "Europe/Moscow"                 
[409] "Europe/Nicosia"                 "Europe/Oslo"                   
[411] "Europe/Paris"                   "Europe/Podgorica"              
[413] "Europe/Prague"                  "Europe/Riga"                   
[415] "Europe/Rome"                    "Europe/Samara"                 
[417] "Europe/San_Marino"              "Europe/Sarajevo"               
[419] "Europe/Saratov"                 "Europe/Simferopol"             
[421] "Europe/Skopje"                  "Europe/Sofia"                  
[423] "Europe/Stockholm"               "Europe/Tallinn"                
[425] "Europe/Tirane"                  "Europe/Tiraspol"               
[427] "Europe/Ulyanovsk"               "Europe/Vaduz"                  
[429] "Europe/Vatican"                 "Europe/Vienna"                 
[431] "Europe/Vilnius"                 "Europe/Volgograd"              
[433] "Europe/Warsaw"                  "Europe/Zagreb"                 
[435] "Europe/Zurich"                  "Factory"                       
[437] "GMT"                            "HST"                           
[439] "Indian/Antananarivo"            "Indian/Chagos"                 
[441] "Indian/Christmas"               "Indian/Cocos"                  
[443] "Indian/Comoro"                  "Indian/Kerguelen"              
[445] "Indian/Mahe"                    "Indian/Maldives"               
[447] "Indian/Mauritius"               "Indian/Mayotte"                
[449] "Indian/Reunion"                 "MET"                           
[451] "MST"                            "MST7MDT"                       
[453] "Pacific/Apia"                   "Pacific/Auckland"              
[455] "Pacific/Bougainville"           "Pacific/Chatham"               
[457] "Pacific/Chuuk"                  "Pacific/Easter"                
[459] "Pacific/Efate"                  "Pacific/Fakaofo"               
[461] "Pacific/Fiji"                   "Pacific/Funafuti"              
[463] "Pacific/Galapagos"              "Pacific/Gambier"               
[465] "Pacific/Guadalcanal"            "Pacific/Guam"                  
[467] "Pacific/Honolulu"               "Pacific/Johnston"              
[469] "Pacific/Kanton"                 "Pacific/Kiritimati"            
[471] "Pacific/Kosrae"                 "Pacific/Kwajalein"             
[473] "Pacific/Majuro"                 "Pacific/Marquesas"             
[475] "Pacific/Midway"                 "Pacific/Nauru"                 
[477] "Pacific/Niue"                   "Pacific/Norfolk"               
[479] "Pacific/Noumea"                 "Pacific/Pago_Pago"             
[481] "Pacific/Palau"                  "Pacific/Pitcairn"              
[483] "Pacific/Pohnpei"                "Pacific/Port_Moresby"          
[485] "Pacific/Rarotonga"              "Pacific/Saipan"                
[487] "Pacific/Samoa"                  "Pacific/Tahiti"                
[489] "Pacific/Tarawa"                 "Pacific/Tongatapu"             
[491] "Pacific/Wake"                   "Pacific/Wallis"                
[493] "Pacific/Yap"                    "PST8PDT"                       
[495] "UTC"                            "WET"                           
attr(,"Version")
[1] "2024a"

In particular, for the specific issue that triggered the CRAN email, the UK5.txt test file reports the time with the EST timezone, which no longer exists in tzdata2024b.

I'm unsure what to do at this stage:

  • We could maintain a compatibility layer to map these deprecated tz to newer timezones. However, the IANA decision was well motivated as these names are ambiguous and map to multiple timezones in the newer version.
  • Trying to do the conversion might have been a bad idea from the start. For example, if a specific region stops/starts using DST, this should be taken into account in the conversion. The only way this would be possible if I understand correctly would be to use the tzdata version from the time of the recording. But it starts getting very complicated. It might be worth making a breaking change at this stage and going back to the behaviour of printing the time exactly as provided by the spectrometer software. The user can then figure out how to harmonize them using dedicated tools if they have files from various sources.

@Bisaloo
Copy link
Member Author

Bisaloo commented Nov 22, 2024

For what it's worth, because it was harder to find than expected, here is the official announcement from upstream: https://lists.iana.org/hyperkitty/list/tz-announce@iana.org/thread/IZ7AO6WRE3W3TWBL5IR6PMQUL433BQIE/

@Bisaloo Bisaloo merged commit e74dac2 into main Dec 1, 2024
4 checks passed
@Bisaloo Bisaloo deleted the fix-tzdata-breaking-change branch December 1, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Bisaloo