Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN package osmextract #259

Closed
agila5 opened this issue Aug 11, 2022 · 1 comment
Closed

CRAN package osmextract #259

agila5 opened this issue Aug 11, 2022 · 1 comment
Assignees

Comments

@agila5
Copy link
Contributor

agila5 commented Aug 11, 2022

Dear maintainer,

Please see the problems shown on
https://cran.r-project.org/web/checks/check_results_osmextract.html.

In particular, please see the "Found the following HTML validation
problems" NOTEs in the "HTML version of manual" check for the r-devel
debian checks results.

R 4.2.0 switched to use HTML5 for documentation pages. Now validation
using HTML Tidy finds problems in the HTML generated from your Rd files
of the form

element removed from HTML5

element removed from HTML5

attribute "align" not allowed for HTML5

attribute "hspace" not allowed for HTML5

attribute "width" has invalid value "120px"

attribute "width" has invalid value "480px"

attribute "width" has invalid value "50px"

attribute "width" has invalid value "72px"

For the first four, please see
https://html.spec.whatwg.org/#obsolete-but-conforming-features for
info on these: in principle, all can be fixed by using style attributes,
e.g.

style='text-align: right;'

instead of align='right' etc., which will work for both the new and old
ways of converting Rd to HTML.

For the second four, simply drop the px units: the HTML5 standard asks
for a non-negative integer implied to be in CSS pixels.

Can you please fix as necessary?

Note that the problems are found in Rd files auto-generated with
roxygen2: to fix it might suffice to re-generate these using the current
CRAN version of roxygen2.

Please correct before 2022-09-01 to safely retain your package on CRAN.

Best,
-k

@agila5
Copy link
Contributor Author

agila5 commented Aug 26, 2022

Manually fixed by manual submission of v0.4.1 as shown in #267

@agila5 agila5 closed this as completed Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant